Skip to content

Loosen coupling of trade site and description files #875

@Kvan7

Description

@Kvan7

Work on a solution to reduce hard requirements of description files and pairing with trade site lines. Description files and game data will always be better than trade site, but reducing the need for users to wait for me to update data at league launch would be nice.

  • Way for ee2 to get stats.json
  • Way for ee2 to get items.json?
  • Remove hard requirement in data builder for description line to exist on trade to get added to stats.ndjson (will be massive amount more stats now)
  • If I have the stat, check each trade id is in valid trade stats set before marking as found.
    • Remove ones that aren't,
    • mark not found if none
  • If I don't have the stat(I should ALWAYS have the stat with the above flow), match string against trade stats list
  • if I have the item, check that the basetype is on trade(and name if unique) fine with the trade site error for this
  • if i don't have the item, (i should have everything except new uniques), lookup in trade data, will ONLY get name out of it
    • with name lookup basetype for it for rest of info (should have basetype) (not needed?)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions