Add setting to prefer 'Base Item' preset on magic items#1015
Open
chrisheib wants to merge 2 commits into
Open
Conversation
Author
|
Regarding the test: Don't think it's related, but there apparently is a typing error in client-log.test.ts, line 1090. |
ec79613 to
69e925d
Compare
0e718db to
a28c830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naive implementation of an 'Prefer Base Item filter on magic items' setting.
Played with it for a bit and it was quite a big help already.
A few open points:
(Btw, took me a while to figure out file writes are disabled in dev mode, I thought I somehow broke the config saving 😅)