Skip to content

Add setting to prefer 'Base Item' preset on magic items#1015

Open
chrisheib wants to merge 2 commits into
Kvan7:masterfrom
chrisheib:feat_baseitem_on_magic
Open

Add setting to prefer 'Base Item' preset on magic items#1015
chrisheib wants to merge 2 commits into
Kvan7:masterfrom
chrisheib:feat_baseitem_on_magic

Conversation

@chrisheib

@chrisheib chrisheib commented Jul 4, 2026

Copy link
Copy Markdown

Naive implementation of an 'Prefer Base Item filter on magic items' setting.

Played with it for a bit and it was quite a big help already.

A few open points:

  • Is this even needed to be configurable? Would there be harm in just falling back to the base item preset for magic items by default?
  • Translations missing
  • I'm not super sure about the early return guard in line 108 in create-preset. I tried it with and without, and for some items (e.g. jewels) without the guard, the filter behaves not as expected, so I think having it in is better. There is certainly a more elegant solution to be found here tho.
  • Positioning in the settings can probably be improved, I just put it randomly, as I don't have a strong opinion here.

(Btw, took me a while to figure out file writes are disabled in dev mode, I thought I somehow broke the config saving 😅)

@chrisheib

Copy link
Copy Markdown
Author

Regarding the test: Don't think it's related, but there apparently is a typing error in client-log.test.ts, line 1090.

---      expect(arg.data.pointType).toBeOneOf(["passive", "weapon-set"]);
+++      expect(["passive", "weapon-set"]).toContain(arg.data.pointType);

@chrisheib chrisheib force-pushed the feat_baseitem_on_magic branch from ec79613 to 69e925d Compare July 4, 2026 23:02
@chrisheib chrisheib force-pushed the feat_baseitem_on_magic branch from 0e718db to a28c830 Compare July 4, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant