Better handling of available events and modifying event types

Author: WojciechMat

frontend/lib/core/repositories/event_repository.dart

@@ -12,7 +12,6 @@ abstract class EventRepository {
   Future<void> notifyParticipants(int eventId, String message);
   Future<TicketType> createTicketType(Map<String, dynamic> data);
   Future<bool> deleteTicketType(int typeId);
-  Future<TicketType> updateTicketType(int typeId, Map<String, dynamic> data);
   Future<List<Location>> getLocations();
 }
 
@@ -33,23 +32,15 @@ class ApiEventRepository implements EventRepository {
     return (data as List).map((e) => Event.fromJson(e)).toList();
   }
 
-  @override
-  Future<TicketType> updateTicketType(int typeId, Map<String, dynamic> data) async {
-    final response = await _apiClient.put('/ticket-types/$typeId', data: data);
-    return TicketType.fromJson(response);
-  }
-
   @override
   Future<List<Event>> getOrganizerEvents(int organizerId) async {
-    final data =
-    await _apiClient.get('/events', queryParams: {'organizer_id': organizerId});
+    final data = await _apiClient.get('/events', queryParams: {'organizer_id': organizerId});
     return (data as List).map((e) => Event.fromJson(e)).toList();
   }
 
   @override
   Future<List<TicketType>> getTicketTypesForEvent(int eventId) async {
-    final data = await _apiClient
-        .get('/ticket-types/', queryParams: {'event_id': eventId});
+    final data = await _apiClient.get('/ticket-types/', queryParams: {'event_id': eventId});
     return (data as List).map((t) => TicketType.fromJson(t)).toList();
   }
 
@@ -82,6 +73,8 @@ class ApiEventRepository implements EventRepository {
     return TicketType.fromJson(response);
   }
 
+  // REMOVED: updateTicketType method
+
   @override
   Future<bool> deleteTicketType(int typeId) async {
     final response = await _apiClient.delete('/ticket-types/$typeId');

frontend/lib/presentation/organizer/cubit/event_form_cubit.dart

@@ -43,7 +43,6 @@ class EventFormCubit extends Cubit<EventFormState> {
     try {
       emit(EventFormTicketTypesLoading());
       final ticketTypes = await _eventRepository.getTicketTypesForEvent(eventId);
-
       emit(EventFormTicketTypesLoaded(ticketTypes));
     } on ApiException catch (e) {
       emit(EventFormError('Failed to load ticket types: ${e.message}'));
@@ -65,44 +64,23 @@ class EventFormCubit extends Cubit<EventFormState> {
     }
   }
 
+  /// Update event details only - ticket types are managed separately
   Future<void> updateEventWithTicketTypes(
     int eventId,
     Map<String, dynamic> eventData,
-    List<TicketType> additionalTicketTypes
+    List<TicketType> newTicketTypes // Only new ticket types to be created
   ) async {
     try {
       emit(const EventFormSubmitting(locations: []));
 
       // 1. Update the event details first
       await _eventRepository.updateEvent(eventId, eventData);
 
-      // 2. Get existing ticket types to compare
-      final existingTicketTypes = await _eventRepository.getTicketTypesForEvent(eventId);
-      final existingAdditionalTypes = existingTicketTypes
-          .where((t) => (t.description ?? '') != "Standard Ticket")
-          .toList();
-
-      // 3. Delete removed ticket types
-      for (final existing in existingAdditionalTypes) {
-        final stillExists = additionalTicketTypes.any((t) =>
-          t.typeId != null && t.typeId == existing.typeId);
-
-        if (!stillExists && existing.typeId != null) {
-          await _eventRepository.deleteTicketType(existing.typeId!);
-          print('Deleted ticket type: ${existing.description}');
-        }
-      }
-
-      // 4. Create or update ticket types
-      for (final ticketType in additionalTicketTypes) {
+      // 2. Create only NEW ticket types (no deletion/updating of existing ones)
+      for (final ticketType in newTicketTypes) {
         if (ticketType.typeId == null) {
-          // Create new ticket type
           await _createSingleTicketType(eventId, ticketType);
           print('Created new ticket type: ${ticketType.description}');
-        } else {
-          // Update existing ticket type
-          await _updateSingleTicketType(ticketType);
-          print('Updated ticket type: ${ticketType.description}');
         }
       }
 
@@ -114,31 +92,41 @@ class EventFormCubit extends Cubit<EventFormState> {
     }
   }
 
-  Future<void> _createSingleTicketType(int eventId, TicketType ticketType) async {
-    if (ticketType.availableFrom == null) {
-      throw Exception('Available from date is required for ticket type: ${ticketType.description}');
-    }
-
-    await _eventRepository.createTicketType({
-      'event_id': eventId,
-      'description': ticketType.description ?? '',
-      'max_count': ticketType.maxCount,
-      'price': ticketType.price,
-      'currency': ticketType.currency,
-      'available_from': ticketType.availableFrom!.toIso8601String(),
-    });
+  bool canDeleteTicketType(TicketType ticketType) {
+    if (ticketType.availableFrom == null) return false;
+    return ticketType.availableFrom!.isAfter(DateTime.now());
   }
 
-  Future<void> _updateSingleTicketType(TicketType ticketType) async {
-    if (ticketType.typeId == null) {
-      throw Exception('Cannot update ticket type without ID');
+  Future<void> deleteTicketType(int typeId, TicketType ticketType) async {
+    try {
+      // Check if deletion is allowed
+      if (!canDeleteTicketType(ticketType)) {
+        emit(EventFormError(
+          'Cannot delete ticket type "${ticketType.description ?? ''}" - sales have already started or no availability date set.'
+        ));
+        return;
+      }
+
+      await _eventRepository.deleteTicketType(typeId);
+      emit(EventFormTicketTypeDeleted());
+
+      if (ticketType.eventId != null) {
+        await loadExistingTicketTypes(ticketType.eventId);
+      }
+    } on ApiException catch (e) {
+      emit(EventFormError(e.message));
+    } catch (e) {
+      emit(EventFormError('Failed to delete ticket type: $e'));
     }
+  }
 
+  Future<void> _createSingleTicketType(int eventId, TicketType ticketType) async {
     if (ticketType.availableFrom == null) {
       throw Exception('Available from date is required for ticket type: ${ticketType.description}');
     }
 
-    await _eventRepository.updateTicketType(ticketType.typeId!, {
+    await _eventRepository.createTicketType({
+      'event_id': eventId,
       'description': ticketType.description ?? '',
       'max_count': ticketType.maxCount,
       'price': ticketType.price,
@@ -151,32 +139,12 @@ class EventFormCubit extends Cubit<EventFormState> {
     try {
       await _createSingleTicketType(eventId, ticketType);
       emit(EventFormTicketTypeCreated());
-    } on ApiException catch (e) {
-      emit(EventFormError(e.message));
-    } catch (e) {
-      emit(EventFormError('Failed to create ticket type: $e'));
-    }
-  }
 
-  Future<void> updateTicketType(TicketType ticketType) async {
-    try {
-      await _updateSingleTicketType(ticketType);
-      emit(EventFormTicketTypeUpdated());
+      await loadExistingTicketTypes(eventId);
     } on ApiException catch (e) {
       emit(EventFormError(e.message));
     } catch (e) {
-      emit(EventFormError('Failed to update ticket type: $e'));
-    }
-  }
-
-  Future<void> deleteTicketType(int typeId) async {
-    try {
-      await _eventRepository.deleteTicketType(typeId);
-      emit(EventFormTicketTypeDeleted());
-    } on ApiException catch (e) {
-      emit(EventFormError(e.message));
-    } catch (e) {
-      emit(EventFormError('Failed to delete ticket type: $e'));
+      emit(EventFormError('Failed to create ticket type: $e'));
     }
   }
 }

frontend/lib/presentation/organizer/cubit/event_form_state.dart

@@ -56,6 +56,4 @@ class EventFormTicketTypesLoaded extends EventFormState {
 
 class EventFormTicketTypeCreated extends EventFormState {}
 
-class EventFormTicketTypeUpdated extends EventFormState {}
-
-class EventFormTicketTypeDeleted extends EventFormState {} // FIXED: Added missing body
+class EventFormTicketTypeDeleted extends EventFormState {}