feat: add GetAllEntities API#92
Open
2vg wants to merge 9 commits intoKxnrl:masterfrom
Open
Conversation
Contributor
Author
|
I asked nuko-sama, and they told me that Created/Destroy is the best option. |
2vg
commented
Apr 4, 2026
Nukoooo
requested changes
Apr 4, 2026
Collaborator
Nukoooo
left a comment
There was a problem hiding this comment.
just some nitpicks, it looks good to me
Nukoooo
approved these changes
Apr 4, 2026
Kxnrl
requested changes
Apr 4, 2026
Owner
|
an entity will fire an OnDeleted event when it is marked as KILL_ME, but at this time the entity is not destroyed and its data/proterties can be safely accessed. I think you might need to consider this special case, as it is quite common with weapon and item entities. OnDeleted even getting fired before OnSpawned. |
Contributor
Author
|
@Kxnrl I've moved it to DeletedPost for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #57
GetAllEntities/GetAllEntitiesByClassnamemethods toIEntityManagerfor retrieving all currently existing entitiesEntityManagerusing an index-based array and auint[] bitset, populated via existingOnEntityCreated/OnEntityDeletedcallbacksIBaseEntity?[16384]array indexed byEntityIndexuint[512] bitsettracks which indices are active, enabling fast enumeration viaBitOperations.TrailingZeroCountwithout scanning empty slotsO(active)time in a sparse stateLogErrortypos.Added
GetAllEntities(): Returns all active entitiesGetAllEntities<T>(): Returns all active entities matching a specific typeGetAllEntitiesByClassname(string classname): Returns all active entities matching a classname (useful for entity types without a dedicated interface, e.g. CPropYadaYada)GetAllEntitiesByClassname<T>(string classname): Returns all active entities matching both a classname and a specific type