Add option to send replies as original author replica by LilasKR · Pull Request #105 · Kyrela/FixTweetBot

LilasKR · 2026-05-18T04:11:12Z

Summary

Adds a new Reply Method option to send fixed-link replies as a replica of the original message author instead of the bot.

This was written with Codex, then tested locally.

Context

Reference: Discord report
https://discord.com/channels/1160873160665731134/1215363563791585350

Changes

Added a Send as Original Author Replica / Send as %{bot} toggle
Sends fixed links through a channel webhook when original author replica mode is enabled
Uses the original message author's display name and avatar for the webhook message
Disables reply mode when webhook sending is enabled, since webhooks cannot reply
Falls back to the normal send path if the webhook cannot be created or retrieved
Keeps original message handling under the existing Original Message setting
Adds Manage Webhooks permission text, including troubleshooting permissions
Updates English and Korean locale strings

Tested

Tested locally after adding the setting column to the local test database.

Bot starts successfully
Slash commands sync successfully
Updated locale YAML files parse successfully
Python syntax checks pass for the touched files

github-actions · 2026-05-18T04:11:21Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

LilasKR · 2026-05-18T04:48:33Z

I have read the CLA Document and I hereby sign the CLA

Kyrela

Thanks for this pull request. I haven't tested it yet, but I have a couple issues with the code.

Don't hesitate to debate/argue with me if you don't agree with some of my comments, I'm open to discussion.

On another note, did you fully vibe-coded it, and/or are you a developper? More details about the implication of AI in this PR would be appreciated.

Kyrela · 2026-05-18T20:06:30Z

The PR is missing the migration file related to this change

Kyrela · 2026-05-18T20:19:24Z

    name: "Reply method"
    description: "Change the behavior on the reply"
-    content: "**Change what to do on the reply**\n- %{state}\n- %{silent}%{perms}"
+    content: "**Change what to do on the reply**\n- %{state}\n- %{silent}\n- %{avatar}%{perms}"


Why "avatar"? That isn't related to the avatar by any mean

Kyrela · 2026-05-18T20:21:31Z

        "false": "🔔 Send with a notification"
+    original_sender_profile:
+      button:
+        "true": "Send as Original Sender Profile"


"original sender profile" doesn't really makes sense imo. Specifially the "profile" part.

"Sending as fake user/author" would be better imo, but, to be closer with what you wrote, "send as original sender/author replica" might also be a solution.

In any case, any change do the naming here have to be mirrored across every symbols of the PR.

Kyrela · 2026-05-18T20:22:37Z

+    original_sender_profile:
+      button:
+        "true": "Send as Original Sender Profile"
+        "false": "Send as Bot Profile"


Same here : "Send as FixTweet" (with, of course, "FixTweet" as determined by the bot's name) seems more adapted.

Kyrela · 2026-05-18T20:30:55Z

+    if not guild.reply_as_original_sender_profile:
+        async with Typing(channel):
+            rendered_links = [link for link in links if await link.render()]
+            if not rendered_links:
+                return
+            not_sent, messages = await send_fixed_links(rendered_links, guild, original_message)
+    else:


Why disabling typing when faking user? It's still a working indicator, so it's kind of important.

Also, If typing had to be disabled, duplicating the code isn't the proper solution.

Kyrela · 2026-05-18T20:36:50Z

It seems to be completely missing the troubleshoot permission update

Kyrela · 2026-05-18T20:40:47Z

        self.ctx.guild.update({'reply_silently': self.reply_silently})
        await view.refresh(interaction)

+    async def toggle_reply_as_original_sender_profile(self, view: SettingsView, interaction: discore.Interaction, _) -> None:


As webhooks can't reply, enabling webhook send should disable the reply method option, both visually and by setting it to "send" in the DB.

Kyrela · 2026-05-18T20:42:50Z

    return links_failed, messages_sent


+async def get_or_create_webhook(channel: discore.TextChannel | discore.Thread) -> discore.Webhook | None:


the typehint for channel isn't good ; this can be a lot more that a TextChannel or a Thread

Kyrela · 2026-05-18T20:47:52Z

+    try:
+        webhooks = await webhook_channel.webhooks()
+    except discore.HTTPException:
+        _logger.exception("Failed to fetch webhooks")
+        return None


HTTPException is too broad and catching an error like this hides it. There should be a narrower error handling or no error handling at all, allowing the global error handler to catch it and report it properly.

Kyrela · 2026-05-18T20:51:19Z

+        if w.name == WEBHOOK_NAME and getattr(w.user, 'id', None) == channel.guild.me.id
+    ), None)
+    if webhook is not None:
+        return webhook
+    sent, webhook = await safe_send_coro(webhook_channel.create_webhook(name=WEBHOOK_NAME), forbidden=True)


WEBHOOK_NAME shouldn't be a variable. Instead, the bot's display name should be used, to avoid confusion and incoherent branding across unofficial instances.

LilasKR · 2026-05-18T22:02:22Z

Thanks for the review!

I’m a UI/UX designer, not a developer. I can read code to some extent, but most of this was vibe-coded with Codex and then adjusted while testing locally.

I agree with most of your points, and I’ll update the PR.

For the typing indicator: I disabled it in webhook mode because the message is sent by a webhook identity instead of the bot user. In my local test, Discord kept showing the bot as typing for a while even after the webhook message had already been sent.

LilasKR force-pushed the codex/20260518-fix branch 2 times, most recently from db978e1 to d9b26b1 Compare May 18, 2026 04:18

LilasKR changed the title ~~[codex] Add original sender profile reply mode~~ Add option to send replies as the original sender May 18, 2026

Kyrela requested changes May 18, 2026

View reviewed changes

LilasKR force-pushed the codex/20260518-fix branch from d9b26b1 to 0f1537d Compare May 18, 2026 22:11

LilasKR changed the title ~~Add option to send replies as the original sender~~ Add option to send replies as original author replica May 18, 2026

Add original sender profile reply mode

451ca15

LilasKR force-pushed the codex/20260518-fix branch from 0f1537d to 451ca15 Compare May 18, 2026 22:17

		return links_failed, messages_sent


		async def get_or_create_webhook(channel: discore.TextChannel \| discore.Thread) -> discore.Webhook \| None:

Uh oh!

Conversation

LilasKR commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Context

Changes

Tested

Uh oh!

github-actions Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LilasKR commented May 18, 2026

Uh oh!

Kyrela left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kyrela May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LilasKR commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LilasKR commented May 18, 2026 •

edited

Loading

github-actions Bot commented May 18, 2026 •

edited

Loading

Kyrela May 18, 2026 •

edited

Loading

LilasKR commented May 18, 2026 •

edited

Loading