Merge pull request #59 from LAA-Software-Engineering/issue/25-validate-cmd

feat(cli): agentctl validate command (closes #25)

Author: leo-aa88

internal/cli/doc.go

@@ -1,3 +1,6 @@
 // Package cli defines agentctl commands, global flags (design doc section 11.1), and exit-code
 // mapping (section 11.2). Output formatting lives in [render].
+//
+// The validate command (section 10.2) loads the project, applies defaults and optional environment
+// overlays, then runs [spec.ValidateProjectGraph].
 package cli

internal/cli/root.go

@@ -33,6 +33,7 @@ func NewRootCmd() *cobra.Command {
 	}
 	BindPersistentFlags(root)
 	root.AddCommand(newVersionCmd())
+	root.AddCommand(newValidateCmd())
 	return root
 }
 

internal/cli/testdata/validate_bad/broken-tool.yaml

@@ -0,0 +1,5 @@
+apiVersion: agentic.dev/v0
+kind: Tool
+metadata:
+  name: broken
+spec: {}

internal/cli/testdata/validate_bad/project.yaml

@@ -0,0 +1,7 @@
+apiVersion: agentic.dev/v0
+kind: Project
+metadata:
+  name: validate-bad
+spec:
+  imports:
+    - ./broken-tool.yaml

internal/cli/testdata/validate_ok/env.yaml

@@ -0,0 +1,10 @@
+apiVersion: agentic.dev/v0
+kind: Environment
+metadata:
+  name: staging
+spec:
+  overrides:
+    policies:
+      default:
+        execution:
+          maxWallClockSeconds: 600

internal/cli/testdata/validate_ok/policy.yaml

@@ -0,0 +1,8 @@
+apiVersion: agentic.dev/v0
+kind: Policy
+metadata:
+  name: default
+spec:
+  execution:
+    maxWallClockSeconds: 300
+    maxTotalCostUsd: 5

internal/cli/testdata/validate_ok/project.yaml

@@ -0,0 +1,17 @@
+apiVersion: agentic.dev/v0
+kind: Project
+metadata:
+  name: validate-ok
+spec:
+  imports:
+    - ./tool.yaml
+    - ./policy.yaml
+    - ./workflow.yaml
+    - ./env.yaml
+  defaults:
+    policy: default
+    model: mock/gpt-4
+  providers:
+    models:
+      mock:
+        type: mock

internal/cli/testdata/validate_ok/tool.yaml

@@ -0,0 +1,6 @@
+apiVersion: agentic.dev/v0
+kind: Tool
+metadata:
+  name: helper
+spec:
+  type: native

internal/cli/testdata/validate_ok/workflow.yaml

@@ -0,0 +1,11 @@
+apiVersion: agentic.dev/v0
+kind: Workflow
+metadata:
+  name: demo
+spec:
+  policy: default
+  steps:
+    - id: ping
+      uses: tool.helper.echo
+      with:
+        msg: "hi"

internal/cli/validate.go

@@ -0,0 +1,124 @@
+package cli
+
+import (
+	"fmt"
+	"path/filepath"
+
+	"github.com/LAA-Software-Engineering/agentic-control-plane/internal/project"
+	"github.com/LAA-Software-Engineering/agentic-control-plane/internal/render"
+	"github.com/LAA-Software-Engineering/agentic-control-plane/internal/runtime/local"
+	"github.com/LAA-Software-Engineering/agentic-control-plane/internal/spec"
+	"github.com/spf13/cobra"
+)
+
+func newValidateCmd() *cobra.Command {
+	return &cobra.Command{
+		Use:          "validate",
+		Short:        "Validate project YAML, references, and schema files",
+		SilenceUsage: true,
+		Long: `Load the project from --project, apply Project defaults, optionally apply
+the selected Environment (-e / --env), then run spec validation.
+
+Exit code 2 indicates validation failure (design doc sections 10.2, 11.2).`,
+		RunE: runValidate,
+	}
+}
+
+func runValidate(cmd *cobra.Command, args []string) error {
+	_ = args
+	g := Globals()
+	root, err := filepath.Abs(filepath.Clean(g.ProjectRoot))
+	if err != nil {
+		return NewExitErrorf(ExitValidationError, "project root: %w", err)
+	}
+
+	graph, err := project.LoadProject(root)
+	if err != nil {
+		return NewExitErrorf(ExitValidationError, "%w", err)
+	}
+
+	spec.NormalizeProjectGraph(graph)
+
+	graph, err = local.ApplyEnvironment(graph, g.Env)
+	if err != nil {
+		return NewExitErrorf(ExitValidationError, "%w", err)
+	}
+
+	if err := spec.ValidateProjectGraph(graph, root); err != nil {
+		return NewExitError(ExitValidationError, err)
+	}
+
+	return writeValidateSuccess(cmd, graph, g)
+}
+
+func writeValidateSuccess(cmd *cobra.Command, graph *spec.ProjectGraph, g *Global) error {
+	out := cmd.OutOrStdout()
+	envLabel := g.Env
+	if envLabel == "" {
+		envLabel = "(none)"
+	}
+	projName := graph.Meta.Name
+	if projName == "" {
+		projName = "(unnamed)"
+	}
+	n := resourceCount(graph)
+
+	switch g.Output {
+	case render.FormatJSON:
+		payload := struct {
+			Project       string `json:"project"`
+			Environment   string `json:"environment"`
+			ResourceCount int    `json:"resourceCount"`
+			Valid         bool   `json:"valid"`
+			Message       string `json:"message"`
+		}{
+			Project:       projName,
+			Environment:   envLabel,
+			ResourceCount: n,
+			Valid:         true,
+			Message:       "Validation successful",
+		}
+		return render.WriteJSON(out, payload)
+	case render.FormatYAML:
+		return render.WriteYAML(out, map[string]any{
+			"project":       projName,
+			"environment":   envLabel,
+			"resourceCount": n,
+			"valid":         true,
+			"message":       "Validation successful",
+		})
+	default:
+		p := passPrefix(g)
+		if _, err := fmt.Fprintf(out, "Project: %s\nEnvironment: %s\n\n", projName, envLabel); err != nil {
+			return err
+		}
+		if _, err := fmt.Fprintf(out, "%s Loaded %d resources\n", p, n); err != nil {
+			return err
+		}
+		if _, err := fmt.Fprintf(out, "%s References resolved\n", p); err != nil {
+			return err
+		}
+		if _, err := fmt.Fprintf(out, "%s Schemas valid\n", p); err != nil {
+			return err
+		}
+		if _, err := fmt.Fprintf(out, "%s All workflows valid\n", p); err != nil {
+			return err
+		}
+		_, err := fmt.Fprintf(out, "\nValidation successful\n")
+		return err
+	}
+}
+
+func resourceCount(g *spec.ProjectGraph) int {
+	if g == nil {
+		return 0
+	}
+	return len(g.Agents) + len(g.Tools) + len(g.Workflows) + len(g.Policies) + len(g.Environments)
+}
+
+func passPrefix(g *Global) string {
+	if g != nil && g.NoColor {
+		return "*"
+	}
+	return "✓"
+}