ci(workflows): validate AGENTCTL_INSTALL allowlist#123
Merged
Conversation
Fail fast when AGENTCTL_INSTALL is not go-build or release, and use explicit == release for the tarball install step instead of != go-build. Document the two allowed values in GITHUB_ACTIONS.md. Fixes #97 Co-authored-by: Cursor <cursoragent@cursor.com>
ReviewGate [WARN]
|
Automated reviewSummaryEnhancements made to validate AGENTCTL_INSTALL values are generally positive. Findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentctl-pr-review.ymlandagentctl-pr-review-publish.ymlthat fails fast with a clear message when the value is notgo-buildorrelease.!= 'go-build'to== 'release'so typos no longer silently select release mode.docs/GITHUB_ACTIONS.md(install table and env table).Fixes #97
Test plan
AGENTCTL_INSTALL: go-buildworkflows still pass on PR (existing monorepo CI).AGENTCTL_INSTALL: relasein a fork/workflow_dispatch test and verify the validate step fails with the expected message.AGENTCTL_INSTALL: release+ pinnedAGENTCTL_VERSIONand confirm release tarball install runs.Made with Cursor