feat(trace): event types, recorder, and reader for runtime store#48
Merged
Conversation
Add Event type alias and Event* constants per design doc §12.2. Recorder checks run exists before Append, marshals Data to JSON, and delegates to RuntimeStore.AppendTraceEvent. Reader wraps ListTraceEventsByRunID. Tests cover monotonic seq per run_id and ErrRunNotFound when the run row is missing (issue #14). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was added
internal/trace/events.goEventalias forstate.TraceEvent; constantsEventRunStarted,EventRunFinished,EventStepStarted,EventStepFinished,EventStepFailed,EventToolCalled,EventToolCompleted,EventModelCalled,EventModelCompleted,EventPolicyDenied.internal/trace/recorder.goRecorderwithAppend(ctx, runID, stepID, typ string, data map[string]any)→ JSONdata_json, optionalClockfor tests. CallsGetRunfirst; onsql.ErrNoRowsreturnsfmt.Errorf(..., %w, ErrRunNotFound). Validates non-emptyrun_idandtype.internal/trace/reader.goReader.ListByRunID→RuntimeStore.ListTraceEventsByRunID.internal/trace/recorder_test.gointernal/trace/doc.goAcceptance
seqfor onerun_id—TestRecorder_Append_increasingSeqPerRunIDusesStartRun+ twoAppendcalls; expects seq1,2and the same viaReader.ListByRunID.TestRecorder_Append_missingRunFailsWithErrRunNotFoundassertserrors.Is(err, ErrRunNotFound)and that the error text includesmissing-run(noStartRun, so no FK-only error).Closes #14.