Fix to remove deprecation warning from Optim.jl#335
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Optim.jl option parameters to remove deprecation warnings by replacing the deprecated f_tol and g_tol parameters with their newer equivalents f_abstol and g_abstol.
Changes:
- Updated default
Optim.Optionsparameters from deprecatedf_tolandg_toltof_abstolandg_abstol
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks @FabsOliveira, I will update the tests and release a new version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests break because of a numerical error with L-BFGS. Should probably revise the tests to be more robust, maybe use another Optim.jl method in there.