diff --git a/src/Lightweight/SqlQuery/Core.hpp b/src/Lightweight/SqlQuery/Core.hpp index e56259342..325f89798 100644 --- a/src/Lightweight/SqlQuery/Core.hpp +++ b/src/Lightweight/SqlQuery/Core.hpp @@ -306,10 +306,6 @@ class [[nodiscard]] SqlWhereClauseBuilder template [[nodiscard]] Derived& WhereFalse(ColumnName const& columnName); - /// Construts or extends a WHERE clause to test for a binary operation between two columns. - template - [[nodiscard]] Derived& WhereColumn(LeftColumn const& left, std::string_view binaryOp, RightColumn const& right); - /// Constructs an INNER JOIN clause. /// /// @param joinTable The table's name to join with. This can be a string, a string_view, or an AliasedTableName. @@ -758,24 +754,6 @@ inline LIGHTWEIGHT_FORCE_INLINE Derived& SqlWhereClauseBuilder::WhereFa return Where(columnName, "=", false); } -/// Constructs or extends a WHERE clause to compare two columns. -template -template -inline LIGHTWEIGHT_FORCE_INLINE Derived& SqlWhereClauseBuilder::WhereColumn(LeftColumn const& left, - std::string_view binaryOp, - RightColumn const& right) -{ - AppendWhereJunctor(); - - AppendColumnName(left); - SearchCondition().condition += ' '; - SearchCondition().condition += binaryOp; - SearchCondition().condition += ' '; - AppendColumnName(right); - - return static_cast(*this); -} - template struct WhereConditionLiteralType { diff --git a/src/tests/QueryBuilderTests.cpp b/src/tests/QueryBuilderTests.cpp index b8fcc3705..7e6eeaa1b 100644 --- a/src/tests/QueryBuilderTests.cpp +++ b/src/tests/QueryBuilderTests.cpp @@ -933,16 +933,6 @@ TEST_CASE_METHOD(SqlTestFixture, "SqlQueryBuilder.Where.Lambda", "[SqlQueryBuild WHERE "a" = 1 OR ("b" = 2 AND "c" = 3))")); } -TEST_CASE_METHOD(SqlTestFixture, "SqlQueryBuilder.WhereColumn", "[SqlQueryBuilder]") -{ - CheckSqlQueryBuilder( - [](SqlQueryBuilder& q) { - return q.FromTable("That").Select().Field("foo").WhereColumn("left", "=", "right").All(); - }, - QueryExpectations::All(R"(SELECT "foo" FROM "That" - WHERE "left" = "right")")); -} - TEST_CASE_METHOD(SqlTestFixture, "Where: SqlQualifiedTableColumnName OP SqlQualifiedTableColumnName", "[SqlQueryBuilder]")