Skip to content

[SqlQuery] Remove unused WhereColumn() #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianparpart merged 1 commit into from
Jul 1, 2026
Merged

[SqlQuery] Remove unused WhereColumn() #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions src/Lightweight/SqlQuery/Core.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,6 @@ class [[nodiscard]] SqlWhereClauseBuilder
template <typename ColumnName>
[[nodiscard]] Derived& WhereFalse(ColumnName const& columnName);

/// Construts or extends a WHERE clause to test for a binary operation between two columns.
template <typename LeftColumn, typename RightColumn>
[[nodiscard]] Derived& WhereColumn(LeftColumn const& left, std::string_view binaryOp, RightColumn const& right);

/// Constructs an INNER JOIN clause.
///
/// @param joinTable The table's name to join with. This can be a string, a string_view, or an AliasedTableName.
Expand Down Expand Up @@ -758,24 +754,6 @@ inline LIGHTWEIGHT_FORCE_INLINE Derived& SqlWhereClauseBuilder<Derived>::WhereFa
return Where(columnName, "=", false);
}

/// Constructs or extends a WHERE clause to compare two columns.
template <typename Derived>
template <typename LeftColumn, typename RightColumn>
inline LIGHTWEIGHT_FORCE_INLINE Derived& SqlWhereClauseBuilder<Derived>::WhereColumn(LeftColumn const& left,
std::string_view binaryOp,
RightColumn const& right)
{
AppendWhereJunctor();

AppendColumnName(left);
SearchCondition().condition += ' ';
SearchCondition().condition += binaryOp;
SearchCondition().condition += ' ';
AppendColumnName(right);

return static_cast<Derived&>(*this);
}

template <typename T>
struct WhereConditionLiteralType
{
Expand Down
10 changes: 0 additions & 10 deletions src/tests/QueryBuilderTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,16 +933,6 @@ TEST_CASE_METHOD(SqlTestFixture, "SqlQueryBuilder.Where.Lambda", "[SqlQueryBuild
WHERE "a" = 1 OR ("b" = 2 AND "c" = 3))"));
}

TEST_CASE_METHOD(SqlTestFixture, "SqlQueryBuilder.WhereColumn", "[SqlQueryBuilder]")
{
CheckSqlQueryBuilder(
[](SqlQueryBuilder& q) {
return q.FromTable("That").Select().Field("foo").WhereColumn("left", "=", "right").All();
},
QueryExpectations::All(R"(SELECT "foo" FROM "That"
WHERE "left" = "right")"));
}

TEST_CASE_METHOD(SqlTestFixture,
"Where: SqlQualifiedTableColumnName OP SqlQualifiedTableColumnName",
"[SqlQueryBuilder]")
Expand Down
Loading