CI round 2: fix the 5 tests broken by earlier commits' side effects

Two more side-effect breakages the first CI fix missed (the
admin_refresh + JobReview type fixes were the only failures
visible in the prior CI run; expanding the log on the new run
surfaced these once the suite started running again).

tests/test_jd_parser.py — 4 tests
  Hard-coded `static/demo_job_description/` paths broke when
  commit `facf822` ("Reorganize docs: SQL into docs/sql/, static
  + pdf_rendered into docs/") moved the fixture directory to
  `docs/static/demo_job_description/`. Production code is fine —
  `src/config.py:STATIC_DIR` was updated in the same commit and
  resolves to the new path. Only the test file's hard-coded
  literals were left behind.
  Fix: prepend `docs` to all four paths.

tests/test_workday_job_source.py::test_adapter_paginates_until_max_or_total
  Test mocked 3 pages of 50 jobs each and asserted `len(fake.calls)
  == 3` because the old `_PAGE_SIZE = 50` made offset land at
  exactly `total = 150` after page 3. Commit `18fde26`
  ("Refresh worker: fix Workday 0-jobs + Ashby chunk timeouts")
  dropped `_PAGE_SIZE` to 20 to dodge Workday's tightened API
  limit, which broke the assertion math.
  Fix: derive page mock + assertion from the live `_PAGE_SIZE`
  constant. The test now works at any page size:
    pages_to_return * _PAGE_SIZE = total → exactly that many
    POSTs land before the offset == total early-stop trips.
  This way the next time Workday changes their limit and we
  bump `_PAGE_SIZE`, the test self-adjusts.

Verified locally: 350/350 pytest pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: LEANDERANTONY

tests/test_jd_parser.py

@@ -44,7 +44,7 @@ def test_extract_job_details_finds_core_fields():
 
 
 def test_parse_jd_file_reads_pdf_fixture():
-    sample_path = Path(__file__).resolve().parents[1] / "static" / "demo_job_description" / "Sample_Job_Description_MLEngineer.pdf"
+    sample_path = Path(__file__).resolve().parents[1] / "docs" / "static" / "demo_job_description" / "Sample_Job_Description_MLEngineer.pdf"
 
     with sample_path.open("rb") as handle:
         parsed = parse_jd_text(handle)
@@ -55,7 +55,7 @@ def test_parse_jd_file_reads_pdf_fixture():
 
 
 def test_parse_jd_file_reads_docx_fixture():
-    sample_path = Path(__file__).resolve().parents[1] / "static" / "demo_job_description" / "Sample_Job_Description_DataAnalyst.docx"
+    sample_path = Path(__file__).resolve().parents[1] / "docs" / "static" / "demo_job_description" / "Sample_Job_Description_DataAnalyst.docx"
 
     with sample_path.open("rb") as handle:
         parsed = parse_jd_text(handle)
@@ -66,7 +66,7 @@ def test_parse_jd_file_reads_docx_fixture():
 
 
 def test_build_job_description_from_pdf_fixture_extracts_expected_signals():
-    sample_path = Path(__file__).resolve().parents[1] / "static" / "demo_job_description" / "Sample_Job_Description_MLEngineer.pdf"
+    sample_path = Path(__file__).resolve().parents[1] / "docs" / "static" / "demo_job_description" / "Sample_Job_Description_MLEngineer.pdf"
 
     with sample_path.open("rb") as handle:
         parsed = parse_jd_text(handle)
@@ -81,7 +81,7 @@ def test_build_job_description_from_pdf_fixture_extracts_expected_signals():
 
 
 def test_build_job_description_from_docx_fixture_extracts_expected_signals():
-    sample_path = Path(__file__).resolve().parents[1] / "static" / "demo_job_description" / "Sample_Job_Description_DataAnalyst.docx"
+    sample_path = Path(__file__).resolve().parents[1] / "docs" / "static" / "demo_job_description" / "Sample_Job_Description_DataAnalyst.docx"
 
     with sample_path.open("rb") as handle:
         parsed = parse_jd_text(handle)

tests/test_workday_job_source.py

@@ -179,24 +179,35 @@ def test_adapter_normalizes_workday_payload_to_jobposting():
 
 
 def test_adapter_paginates_until_max_or_total():
-    """Workday returns up to 50 per page; the adapter walks pages
-    until it hits MAX_JOBS_PER_BOARD (250) OR the payload's total.
-    Pin both: verify the right number of POSTs went out and the
-    union of results came through."""
+    """The adapter walks pages until it hits MAX_JOBS_PER_BOARD OR the
+    payload's `total`, whichever fires first. Pin both: verify the
+    right number of POSTs went out and the union of results came
+    through.
+
+    Test reads `_PAGE_SIZE` from the module instead of hard-coding so
+    a later page-size change (e.g. when Workday tightens API limits
+    again) doesn't re-break the test. We just need the math to land
+    cleanly: PAGES_TO_RETURN pages × _PAGE_SIZE per page = total,
+    so the early-stop hits exactly when `offset == total`.
+    """
+    from src.job_sources.workday import _PAGE_SIZE
+
     api_url = (
         "https://nvidia.wd5.myworkdayjobs.com/wday/cxs/"
         "nvidia/NVIDIAExternalCareerSite/jobs"
     )
-    # Three pages of 50 each = 150 jobs total. Adapter should stop
-    # after page 3 (4th page would be empty).
+
+    PAGES_TO_RETURN = 3
+    total = _PAGE_SIZE * PAGES_TO_RETURN
     pages = [
-        {"jobPostings": [_job_payload(req_id=f"R{i}", title=f"Job {i}") for i in range(50)],
-         "total": 150},
-        {"jobPostings": [_job_payload(req_id=f"R{50+i}", title=f"Job {50+i}") for i in range(50)],
-         "total": 150},
-        {"jobPostings": [_job_payload(req_id=f"R{100+i}", title=f"Job {100+i}") for i in range(50)],
-         "total": 150},
-        {"jobPostings": [], "total": 150},  # Should not be reached
+        {
+            "jobPostings": [
+                _job_payload(req_id=f"R{p * _PAGE_SIZE + i}", title=f"Job {p * _PAGE_SIZE + i}")
+                for i in range(_PAGE_SIZE)
+            ],
+            "total": total,
+        }
+        for p in range(PAGES_TO_RETURN)
     ]
     fake = _FakeSession({api_url: pages})
     adapter = WorkdayJobSourceAdapter(
@@ -207,10 +218,11 @@ def test_adapter_paginates_until_max_or_total():
     assert len(results) == 1
     label, status, postings = results[0]
     assert status == "ok"
-    assert len(postings) == 150
-    # 3 POST calls (the 4th empty page never reached because offset
-    # 150 >= total 150 trips the early-stop condition).
-    assert len(fake.calls) == 3
+    assert len(postings) == total
+    # PAGES_TO_RETURN POSTs — the next page never gets requested
+    # because the offset == total early-stop trips immediately after
+    # the last full page.
+    assert len(fake.calls) == PAGES_TO_RETURN
 
 
 def test_adapter_unconfigured_returns_not_configured():