test: cover policy template loading#394
Open
aayushprsingh wants to merge 1 commit into
Open
Conversation
Signed-off-by: Aayush Pratap Singh <as456pratapayush@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Vitest coverage for the policy templates loader to ensure shipped templates load cleanly and key lookup/default-enabled behaviors work.
Changes:
- Introduces a new test suite validating template loading returns no errors.
- Adds coverage for case-insensitive template lookup and default-enabled template selection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| expect(result.loadedFrom).toBeTruthy(); | ||
| expect(result.errors).toEqual([]); | ||
| expect(result.templates.length).toBeGreaterThanOrEqual(5); |
Comment on lines
+23
to
+24
| const ciTemplate = findPolicyTemplate("NO-CI-MODIFICATION"); | ||
| const defaultEnabled = getDefaultEnabledTemplates(); |
|
|
||
| describe("policy templates loader", () => { | ||
| it("loads shipped policy templates without compile errors", () => { | ||
| clearPolicyTemplateCache(); |
| }); | ||
|
|
||
| it("finds templates case-insensitively and exposes default-enabled templates", () => { | ||
| clearPolicyTemplateCache(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playbooks/policy-templatesTest plan
corepack pnpm vitest run server/src/__tests__/policy-templates-loader.test.tscorepack pnpm check:tokenscorepack pnpm --filter @gitmesh/server typecheck(fails on current main because ExpressRequest.actoraugmentation fileserver/src/types/express.d.tsis missing; unrelated to this test-only change)