fix(forge-sync): correct inbound webhook routing and webhook path alignment#433
Open
AnuragGupta181 wants to merge 2 commits into
Open
Conversation
Signed-off-by: anurag gupta <job4anurag11@gmail.com>
This file was committed by mistake. It was created for personal assessment purposes only and is not required for this branch. Signed-off-by: Anurag Gupta <job4anurag11@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
fix(forge-sync): correct inbound webhook routing and webhook path alignment
Summary
This PR resolves the highest-priority Phase 0 issue identified during the Forge Integration Service assessment.
Root Cause
GitHub webhooks were registered with the callback URL:
However, the webhook handlers were mounted under:
This routing mismatch caused all inbound GitHub webhook deliveries to return HTTP 404, preventing real-time synchronization and agent wakeups.
Changes Made
Split forge webhook routes into:
forgeWebhookManagementRoutesforgeWebhookInboundRoutesMounted inbound webhook routes at:
/api/forge/webhook/github/api/forge/webhook/gitlab/api/forge/webhook/forgejoKept management routes under project-scoped paths
Updated route exports and wiring
Updated webhook documentation
Aligned inbound routing with existing Tekton webhook architecture
Outcome
Inbound webhook requests now reach the correct handler and no longer fail with HTTP 404 responses.
During validation, an additional issue was discovered:
currently depends on:
which is unavailable in the new inbound webhook execution path.
This causes webhook processing to fail after routing succeeds and will be addressed in a follow-up PR.
Related Issue
Fixes #431
Type of Change
How Was This Tested?
Notes
Validation performed by:
Results:
CE & Security Check
Screenshots / Demos
Before
After
Follow-up Work
The following items remain outside the scope of this PR:
__gitmesh_project_id)Checklist