eps_g definition changed, now consistent with u_g and v_g0

Author: hmonroedd

examples/sparging_standard.py

@@ -24,7 +24,6 @@
 print(f"Pi = {standard_input.get_Pi_number():.2f}")
 print(f"steady state c_T2 = {standard_input.get_c_T2_SS():.2e}")
 print(f"Bo = {standard_input.get_Bo():.2e}")
-standard_input.test_eps_g()
 
 standard_input.c_T2_init = 3e-11 * ureg.molT2 / ureg.m**3
 
@@ -46,14 +45,16 @@
         "n_T2_salt",
         "ndot_T2",
         "J_T2",
+        "eps_g",
+        "u_g",
     ]
     output = my_simulation.solve(fast_solve=True)
 
     # save output to file
     output.exports_to_csv(FOLDER)
     output.to_json(
         FOLDER / "summary.json",
-        ["analytical_quantities", "fit_summary"],
+        ["analytical_quantities", "fit_summary", "intermediate_params"],
     )
 
     animation.create_animation(output, show_activity=False)

src/sparging/correlations.py

@@ -462,22 +462,6 @@ def get_v_g0(Eo, Mo, mu_l, rho_l, d_b) -> float:  # TODO move inside class ?
     return v_g0
 
 
-def get_eps_g(T, P_g, ndot_g, area, v_g) -> float:
-    gamma = ndot_g * const_R * T / (P_g * area * v_g)
-
-    eps_g = gamma / (1 + gamma)
-
-    if np.max(eps_g) > 1 * ureg("dimensionless") or np.min(eps_g) < 0 * ureg(
-        "dimensionless"
-    ):
-        warnings.warn(f"Warning: unphysical gas fraction: {eps_g}")
-    elif np.max(eps_g) > 0.1 * ureg("dimensionless"):
-        warnings.warn(
-            f"Warning: high gas fraction: {eps_g}, model assumptions may not hold"
-        )
-    return eps_g
-
-
 def get_h_higbie(D_l: float, v_g: float, d_b: float) -> float:
     """
     Higbie penetration model average mass transfer coefficient [m/s]-> suited for large mobile interfaces
@@ -530,19 +514,12 @@ def get_h_briggs(Re: float, Sc: float, D_l: float, d_b: float) -> float:
 )
 all_correlations.append(d_b)
 
+
 eps_g = Profile(
     identifier="eps_g",
-    function=lambda temperature, P_g, ndot_g0, area, v_g0: (
-        lambda z: get_eps_g(
-            T=temperature,
-            P_g=P_g(z),
-            ndot_g=ndot_g0,
-            area=area,
-            v_g=v_g0,
-        )
-    ),
+    function=lambda u_g, v_g0: lambda z: u_g(z) / v_g0,
     corr_type=CorrelationType.GAS_VOID_FRACTION,
-    input_units=["kelvin", PROFILE, "mol/s", "m^2", "m/s"],
+    input_units=[PROFILE, "m/s"],
     output_units="dimensionless",
     description="gas void fraction profile (local P and d_b)",
 )

src/sparging/inputs.py

@@ -203,13 +203,6 @@ def get_Bo(self) -> pint.Quantity:
         """
         return (self.u_g0 * self.height / self.E_g).to("dimensionless")
 
-    def test_eps_g(
-        self,
-    ):  # to see if the two definitions of superficial velocity are consistent -> TODO remove
-        print(
-            f"{self.eps_g0 * self.graph.nodes['v_g0']['value']} vs {self.graph.nodes['Vdot_g0']['value'] / self.area} vs {self.u_g0}"
-        )
-
     def __post_init__(self):
         # make sure there are only pint.Quantity or callables in the input, otherwise raise an error
         for key in self.required_scalars: