minor editing

Author: hmonroedd

examples/sparging_standard.py

@@ -41,10 +41,15 @@
 )
 
 if __name__ == "__main__":
+    # my_simulation.exports = ["pressure", "J_T2"]
     output = my_simulation.solve(fast_solve=True)
     # save output to file
     output.to_json(FOLDER / "params.json")
 
+    # P = output.exported_fields["pressure"]
+    # plt.plot(output.x_ct, P)
+    # output.exports_to_csv(FOLDER)
+
     output.profiles_to_csv(FOLDER)
     output.profiles_to_cdf(FOLDER)
 

src/sparging/correlations.py

@@ -424,6 +424,17 @@ def get_list(self, corr_type: CorrelationType) -> list[Correlation]:
 )
 all_correlations.append(source_T_integral)
 
+# P_hydrostatic = Profile(
+#     identifier="P_l",
+#     function=lambda P_bottom, rho_l: (
+#         lambda z: P_bottom - rho_l * const_g * z
+#     ),  # source term for tritium generation calculated from TBR and neutron generation rate
+#     corr_type=CorrelationType.TRITIUM_SOURCE,
+#     input_units=["triton/neutron", "neutron/s"],
+#     output_units="molT/s",
+# )
+# all_correlations.append(source_T_integral)
+
 
 def get_d_b(
     flow_g_vol: pint.Quantity, nozzle_diameter: pint.Quantity, nb_nozzle: pint.Quantity

src/sparging/model.py

@@ -26,13 +26,7 @@
 
 logger = logging.getLogger(__name__)
 
-hours_to_seconds = 3600
-days_to_seconds = 24 * hours_to_seconds
-T2_to_T = 2
-T_to_T2 = 1 / T2_to_T
-
 EPS = 1e-26
-SEPARATOR_KEYWORD = "from"
 
 # log.set_log_level(log.LogLevel.INFO)
 
@@ -275,7 +269,9 @@ class Simulation:
     profile_pressure_hydrostatic: bool = True
     dispersion_on: bool = True
 
-    def hydrostatic_pressure(self, z: pint.Quantity) -> pint.Quantity:
+    def hydrostatic_pressure(
+        self, z: pint.Quantity
+    ) -> pint.Quantity:  # TODO should be in correlations
         """returns the hydrostatic pressure at a given height z in the tank given P_bottom"""
         rho = self.sim_input.rho_l
         g = const_g
@@ -547,7 +543,6 @@ def post_process(t):
             inventory_T2_salt *= tank_area  # get total amount of T2 in [mol]
             inventories_T2_salt.append(inventory_T2_salt)
 
-        # TODO Initialize results storage with zeros -> there's an inconsistency: times[0] = 0 but inventories[0] != 0 -> screws comparison with analytical solutions
         t = 0
         times = []
         c_T2_solutions = []
@@ -556,6 +551,7 @@ def post_process(t):
         sources_T2 = []
         fluxes_T2 = []
         inventories_T2_salt = []
+        # initialize (t=0)
         post_process(t)
 
         # SOLVE