Fix typo and add throw exception as getCommonBlock is not implemented#211
Merged
Conversation
nicolaslg
reviewed
Feb 18, 2026
Collaborator
nicolaslg
left a comment
nicolaslg
left a comment
There was a problem hiding this comment.
I suggest either
- implementing the
getCommonBlockmethod - removing it altogether, including where it is called at https://github.com/LIHPC-Computational-Geometry/magix3d/blob/main/src/Core/Topo/CommandNewTopo.cpp#L126
nicolaslg
reviewed
Feb 18, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 48.86% 48.84% -0.02%
==========================================
Files 466 466
Lines 50515 50537 +22
==========================================
+ Hits 24682 24685 +3
- Misses 25833 25852 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
getCommonBlock implemented as suggested |
mpoudot
force-pushed
the
cmd-new-topo
branch
2 times, most recently
from
4f1b791 to
84d66bb
Compare
nicolaslg
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.