Skip to content

Fix issue#261: mesh becomes invisible if associated geom and topo entities in same group#231

Merged
lelandaisb merged 1 commit into
mainfrom
issue#261
Apr 21, 2026
Merged

Fix issue#261: mesh becomes invisible if associated geom and topo entities in same group#231
lelandaisb merged 1 commit into
mainfrom
issue#261

Conversation

@lelandaisb
Copy link
Copy Markdown
Contributor

Mesh is invisible if topo entity and geom entity belong to the same group

@lelandaisb lelandaisb requested a review from SimonCald April 3, 2026 10:00
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.87%. Comparing base (1eb2502) to head (3e1b1a7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   48.84%   48.87%   +0.02%     
==========================================
  Files         466      466              
  Lines       50507    50514       +7     
==========================================
+ Hits        24672    24690      +18     
+ Misses      25835    25824      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lelandaisb lelandaisb changed the title Fix issue#261 with new unit test Fix issue#261 Apr 3, 2026
@lelandaisb lelandaisb changed the title Fix issue#261 Fix issue#261: mesh becomes invisible if associated geom and topo entities in same group Apr 3, 2026
@nicolaslg
Copy link
Copy Markdown
Collaborator

I might have missed something, but running this script

# Création d'une boite avec une topologie
ctx.getTopoManager().newBoxWithTopo (Mgx3D.Point(0, 0, 0), Mgx3D.Point(1, 1, 1), 10, 10, 10)
# Annulation de : Création d'une boite avec une topologie
ctx.undo()
# Création d'une boite avec une topologie
ctx.getTopoManager().newBoxWithTopo (Mgx3D.Point(0, 0, 0), Mgx3D.Point(1, 1, 1), 10, 10, 10, "aaa")
# Modifie le groupe aaa
ctx.getTopoManager().addToGroup (["Bl0000"], 3, "aaa")
# Création du maillage pour tous les blocs
ctx.getMeshManager().newAllBlocksMesh()

the mesh is not displayed ?

@lelandaisb lelandaisb force-pushed the issue#261 branch 2 times, most recently from f814afd to dcbe53f Compare April 20, 2026 14:18
# Conflicts:
#	test_link/test_groups.py
@lelandaisb lelandaisb merged commit 2afd1a9 into main Apr 21, 2026
2 checks passed
@lelandaisb lelandaisb deleted the issue#261 branch April 21, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants