Skip to content

Commit b2f420b

Browse files
committed
linstor: implement missing deleteDatastore (apache#10561)
Somehow deleteDatastore was never implemented, that meant: templates haven't been cleaned up on datastore delete and also agents have never been informed about storage pool removal.
1 parent eedf6d3 commit b2f420b

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

plugins/storage/volume/linstor/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ All notable changes to Linstor CloudStack plugin will be documented in this file
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [2025-03-13]
9+
10+
### Fixed
11+
12+
- Implemented missing delete datastore, to correctly cleanup on datastore removal
13+
814
## [2025-02-21]
915

1016
### Fixed

plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/LinstorPrimaryDataStoreLifeCycleImpl.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,10 @@ public boolean cancelMaintain(DataStore store) {
287287

288288
@Override
289289
public boolean deleteDataStore(DataStore store) {
290-
return dataStoreHelper.deletePrimaryDataStore(store);
290+
if (cleanupDatastore(store)) {
291+
return dataStoreHelper.deletePrimaryDataStore(store);
292+
}
293+
return false;
291294
}
292295

293296
/* (non-Javadoc)

0 commit comments

Comments
 (0)