fix(k6): make integration test resolve action hash from account-level list - #593
Open
GTC6244 wants to merge 4 commits into
Open
fix(k6): make integration test resolve action hash from account-level list#593GTC6244 wants to merge 4 commits into
GTC6244 wants to merge 4 commits into
Conversation
The correctness integration test derived the action hash from the in-group list_actions response, which depends on add_action_to_group membership propagation. When that on-chain read lagged the write, the action was absent, hashedCid resolved to "", and the server rejected update_action_metadata with "Cannot update action with hash 0x0". Source the hash from the account-level list (already verified to contain the action) and guard against an empty/0x0 hash. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the k6-correctness / correctness integration test by resolving the Lit Action hash from the account-level /list_actions response rather than the in-group listing, avoiding flakiness caused by on-chain group-membership propagation lag.
Changes:
- Source
hashedCidfrom the account-levellistActionsAccountResresponse instead of the in-grouplistActionsRes. - Add a guard check to fail clearly before calling
updateActionMetadatawhen the resolved action hash is missing/invalid.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
k6-correctness / correctnessintegration test was failing in Deploy Staging withupdateActionMetadata | 400 | Cannot update action with hash 0x0. The test derived the action hash from the in-grouplist_actionsresponse, which depends onadd_action_to_groupmembership being visible on-chain; when that read lagged the write, the action was absent andhashedCidresolved to"", which the server parses toU256::ZEROand rejects. This sources the hash from the account-level list instead (already verified to contain the action, and independent of group-membership propagation) and adds a guard that fails clearly on an empty/0x0hash. The two prior main failures were a separate transientnewAccount 500 NoAccountAccessissue, not addressed here.🤖 Generated with Claude Code