Skip to content

fix(monitor): use optionalChains for WalletConnect Safe compatibility #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GTC6244 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(monitor): use optionalChains for WalletConnect Safe compatibility #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lit-static/dapps/monitor/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,19 @@ async function connectWallet() {
try {
_wcProvider = await EthereumProvider.init({
projectId: WALLETCONNECT_PROJECT_ID,
chains: [chainId],
// CRITICAL: use `optionalChains`, NOT `chains`. @walletconnect/ethereum-provider
// turns `chains` into a *requiredNamespaces* entry. A Gnosis Safe (and any
// smart-contract wallet) only supports the single chain it was deployed to, and
// Reown's own guidance is explicit that required namespaces "cause issues" with
// such wallets: the session pairs successfully (the Safe app opens) but the
// eth_sendTransaction request never routes to the wallet, so the transaction to
// sign silently disappears. Declaring the chain as *optional* keeps EOA wallets
// (MetaMask, Rabby) working while letting the Safe negotiate its single chain.
// Methods intentionally left unset → they default to the full OPTIONAL_METHODS
// set (includes eth_sendTransaction), which the wallet echoes into the approved
// namespace so signing routes to the wallet rather than the read-only RPC.
// See https://docs.reown.com/advanced/providers/ethereum ("Smart Contract Wallets").
optionalChains: [chainId],
rpcMap: rpcUrl ? { [chainId]: rpcUrl } : undefined,
showQrModal: true,
});
Expand Down
Loading