fix(ci): Contract Upgrade checks out main, not the retired next branch - #599
Merged
Conversation
The Contract Upgrade workflow used `ref: ${{ inputs.branch }}` and then
read `NodeConfig.<branch>.toml` from that checkout. Dispatching with the
default (`next`) checked out the retired `next` branch, whose
NodeConfig.next.toml was deleted in CPL-272 when main took over staging
deploys — so the run failed with "NodeConfig.next.toml not found".
All NodeConfig.*.toml files now live on main, so always check out main and
let the input select only which config to read. Renamed the input from
`branch` to `target` to reflect that it picks a deploy target, not a git ref.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the manual Contract Upgrade GitHub Actions workflow so it no longer checks out the retired next git branch when using the default dispatch input, while still allowing operators to choose which NodeConfig.<target>.toml (e.g., main vs next) to read for deployment configuration.
Changes:
- Renames the dispatch input from
branch→targetto reflect it selects a deploy target/config, not a git ref. - Forces
actions/checkoutto always check outmain. - Updates concurrency grouping and config selection to use
inputs.target.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Contract Upgrade workflow failed with
lit-api-server/NodeConfig.next.toml not found(run 29962175213), even though that file exists onmain.Root cause: the workflow coupled two things that shouldn't be coupled:
actions/checkoutusedref: ${{ inputs.branch }}(defaultnext), andNodeConfig.<branch>.tomlfrom that checkout.Dispatching with the default
nextchecked out thenextbranch — which was retired in CPL-272 (3b0a7a2e, "main now drives staging deploys") and had itsNodeConfig.next.tomldeleted.origin/nextis now 481 commits behindmain.Fix
All
NodeConfig.*.tomlfiles now live onmain(NodeConfig.main.tomlandNodeConfig.next.tomlboth present). So:main.branch→targetto reflect it picks a deploy target, not a git ref.Both
nextandmaintargets now resolve their config correctly.🤖 Generated with Claude Code