Skip to content

feat: Add GoF Design Patterns semantic anchor#140

Merged
rdmueller merged 1 commit into
LLM-Coding:mainfrom
Nantero1:add-anchor-gof-design-patterns
Mar 9, 2026
Merged

feat: Add GoF Design Patterns semantic anchor#140
rdmueller merged 1 commit into
LLM-Coding:mainfrom
Nantero1:add-anchor-gof-design-patterns

Conversation

@Nantero1

@Nantero1 Nantero1 commented Mar 7, 2026

Copy link
Copy Markdown

Summary

  • Adds GoF Design Patterns as a new semantic anchor
  • Covers Gamma/Helm/Johnson/Vlissides' 23 OO design patterns (1994)
  • Includes anchor file, all-anchors include, and AgentSkill catalog entry

Why this anchor?

GoF activates: 23 patterns in 3 categories (Creational, Structural, Behavioral), pattern language as shared vocabulary, composition over inheritance, program to an interface, design for change.

Distinct from: Fowler Patterns (enterprise application architecture — Repository, Unit of Work, Data Mapper). GoF = OO object collaboration and reuse; Fowler = application-layer structure.

"Fowler Patterns" already exists as an anchor but covers PEAA, not GoF. These are complementary but separate bodies of knowledge.

Files changed

  • docs/anchors/gof-design-patterns.adoc — new anchor file
  • docs/all-anchors.adoc — added include in Design Principles section
  • skill/semantic-anchor-translator/references/catalog.md — added catalog entry

Adds Gang of Four Design Patterns as a standalone semantic anchor
covering Gamma/Helm/Johnson/Vlissides' 23 OO design patterns.
Distinct from Fowler Patterns (enterprise application architecture)
— GoF covers OO object collaboration and reuse.
@coderabbitai

coderabbitai Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Nantero1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ca7fdad4-79ad-4e0f-bcde-5da04e360fde

📥 Commits

Reviewing files that changed from the base of the PR and between aefa0b4 and d6e8371.

📒 Files selected for processing (3)
  • docs/all-anchors.adoc
  • docs/anchors/gof-design-patterns.adoc
  • skill/semantic-anchor-translator/references/catalog.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@raifdmueller

Copy link
Copy Markdown
Contributor

Review: ✅ Good anchor, merge-ready.

GoF Design Patterns works well as a "meta-anchor" — consistent with how we handle "Fowler Patterns (PEAA)". The term activates rich context about the entire pattern catalog and the shared design vocabulary.

New concept: Umbrella Anchors with Sub-Anchors

We're planning a two-level anchor system:

  • Level 1 (Main catalog): GoF Design Patterns as umbrella anchor
  • Level 2 (Linked sub-anchors): Individual patterns (Strategy, Observer, Decorator, etc.) as optional expansion

Individual GoF patterns DO make good semantic anchors with strong prompts (e.g. "Extract the varying algorithm into a Strategy pattern"). But instead of flooding the main catalog with 23 entries, they'll be linked from the umbrella card.

Visual concept for cards: Umbrella cards will look like a stack of 3 cards behind each other, visually signaling "there's more inside."

See #149 for the broader discussion.

Post-merge TODO:

  • Add German translation (gof-design-patterns.de.adoc)

Merging recommended, translation will follow in batch.

@rdmueller rdmueller merged commit c81dacd into LLM-Coding:main Mar 9, 2026
8 checks passed
raifdmueller added a commit to raifdmueller/Semantic-Anchors that referenced this pull request Mar 9, 2026
LLM-Coding#138, LLM-Coding#139)

Content from @Nantero1's original PRs LLM-Coding#138 and LLM-Coding#139, rebased on current main
after merging LLM-Coding#137, LLM-Coding#140, LLM-Coding#142, LLM-Coding#143.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants