Skip to content

feat: expand Semantic Contracts to cover full workflow + fix More menu#369

Merged
rdmueller merged 2 commits into
LLM-Coding:mainfrom
raifdmueller:feat/contracts-expansion
Mar 26, 2026
Merged

feat: expand Semantic Contracts to cover full workflow + fix More menu#369
rdmueller merged 2 commits into
LLM-Coding:mainfrom
raifdmueller:feat/contracts-expansion

Conversation

@raifdmueller
Copy link
Copy Markdown
Contributor

@raifdmueller raifdmueller commented Mar 26, 2026

Summary

Expanded from 7 to 11 Semantic Contracts, now covering all 5 workflow phases:

Contract Phase Anchors
Requirements Discovery Phase 1 Socratic Method, MECE, PRD
Specification Phase 1 Gherkin, BDD
Architecture Documentation Phase 2 arc42, C4, ADR Nygard, Pugh Matrix
Layer Boundaries Phase 2 Clean/Hexagonal Architecture, DDD, SOLID
Backlog Management Phase 3 INVEST, MoSCoW
Implement Next Phase 4 TDD, Definition of Done, Conventional Commits
Code Quality Phase 4 SOLID, DRY, KISS, DDD (Ubiquitous Language)
Quality Review Phase 5 Fagan Inspection, OWASP Top 10, ATAM
Docs-as-Code Cross-cutting Docs-as-Code (Müller), Strunk & White
Concise Response Communication BLUF, Strunk & White
Simple Explanation Communication Feynman Technique

Also fixed

  • "More" dropdown menu now works (JS click toggle instead of CSS group-hover)

Test plan

  • All 88 unit tests pass
  • Lint clean
  • Verify More menu opens/closes
  • Verify all 11 contracts render on contracts page

🤖 Generated with Claude Code

Summary by CodeRabbit

Neue Features

  • Umfassende Workflow- und Richtlinien-Pakete hinzugefügt: Anforderungserfassung, Backlog-Management, Implementierungsprozess, Qualitätsprüfung und Docs-as-Code-Standards
  • Dropdown-Navigationsmenü mit voller Interaktivität erweitert
  • Architektur-Dokumentationsprozess um strukturierte Evaluationsmethoden ergänzt

Sonstiges

  • Navigationsbezeichnung aktualisiert: „Katalog" → „Anchors"

New contracts (from workflow phases):
- Requirements Discovery (Socratic Method, MECE, PRD)
- Backlog Management (INVEST, MoSCoW)
- Implement Next (TDD, Conventional Commits, Definition of Done)
- Quality Review (Fagan Inspection, OWASP Top 10, ATAM)

Updated contracts:
- Architecture Documentation: added Pugh Matrix (-1/0/+1) for ADRs
- Code Quality: separated TDD into Implement Next, kept SOLID/DRY/KISS/DDD
- Documentation Style: renamed to "Docs-as-Code", added docToolchain/PlantUML

Fixed: More menu now uses JS click toggle instead of broken CSS group-hover.

11 contracts total, covering all 5 workflow phases.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 26, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Neue Semantic-Contracts (Requirements Discovery, Backlog Management, Implement Next, Quality Review, Docs-as-Code) wurden zu contracts.json hinzugefügt und vorhandene Contracts (Architecture Documentation, Code Quality) wurden aktualisiert. Die Navigation wurde von "Catalog" zu "Anchors" umbenannt. Das Dropdown-Menü wurde von CSS-basiertem Hover zu expliziter ID-gestützter Implementierung umgestellt.

Changes

Cohort / File(s) Zusammenfassung
Semantic Contracts
website/public/data/contracts.json
Fünf neue Contract-Einträge hinzugefügt (Requirements Discovery, Backlog Management, Implement Next, Quality Review, Docs-as-Code); zwei vorhandene Contracts aktualisiert (Architecture Documentation mit Pugh Matrix und PlantUML C4-Diagrammen; Code Quality mit SOLID/DRY/KISS/DDD-Fokus); documentation-style durch Docs-as-Code ersetzt.
Dropdown-Menü-Implementierung
website/src/components/header.js, website/src/main.js
Header: Dropdown von CSS-group-hover zu ID-basierten Elementen (more-menu-container, more-menu-toggle, more-menu-dropdown) umgestellt. Main.js: neue bindMoreMenu()-Funktion für Toggle-, Außenklick- und Link-Klick-Behandlung hinzugefügt.
Navigations-Übersetzungen
website/src/translations/en.json, website/src/translations/de.json
Label für nav.catalog von "Catalog"/"Katalog" zu "Anchors" geändert, um Navigation mit den neuen Semantic Anchors abzustimmen.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Der Titel beschreibt genau die zwei Hauptänderungen: die Erweiterung der Semantic Contracts und die Behebung des More-Menüs. Er ist präzise, nicht zu lang und vermittelt die primären Änderungen klar.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Clearer pairing: Anchors (building blocks) + Contracts (compositions).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants