fix: POSIX sh compatibility and Feynman grammar#406
Merged
rdmueller merged 3 commits intoApr 6, 2026
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughShebang und Shell-Flags in einem Onboarding-Skript reduziert; umfangreiche Umstrukturierung und Erweiterung zweier semantic-anchor-Katalogdokumente (Test-Doubles, SOLID, GoF-Patterns); Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 Minuten Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skill/semantic-anchor-translator/references/catalog.md`:
- Around line 226-229: Die Katalogdatei references/catalog.md ist nicht
vollständig mit docs/anchors/ synchronisiert (nur 92/123 Basisanker erfasst);
update references/catalog.md so that every anchor file in docs/anchors/ is
represented (total 123 unique base anchors), add the missing entries such as all
GoF-Patterns variants, SOLID-Prinzipien, Architecture Patterns (Hexagonal,
Event-Driven, Vertical Slice), Domain-Driven Design, Five Whys, Chain of
Thought, Test-Double-Varianten, and correct the "Feynman Technique" wording if
needed; ensure entries are unique, follow the existing catalog heading format
(e.g., the "### Feynman Technique" block) and regenerate or run any sync
script/test that enforces "references/catalog.md: Muss synchron mit
docs/anchors/ bleiben" to verify counts match.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 9f790870-12c3-4205-ae04-53992c7e7300
📒 Files selected for processing (3)
plugins/semantic-anchors/scripts/prompt-onboarding.shplugins/semantic-anchors/skills/semantic-anchor-translator/references/catalog.mdskill/semantic-anchor-translator/references/catalog.md
- prompt-onboarding.sh: #!/bin/bash + pipefail → #!/bin/sh + set -eu - catalog.md: "Explain concept simply" → "Explain concepts simply" Addresses review findings from PR LLM-Coding#203. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Catalog (skill/ + synced plugins/): - Add individual ### entries for all 23 GoF patterns (Abstract Factory, Builder, Factory Method, Prototype, Singleton, Adapter, Bridge, Composite, Decorator, Facade, Flyweight, Proxy, Chain of Responsibility, Command, Interpreter, Iterator, Mediator, Memento, Observer, State, Strategy, Template Method, Visitor) - Promote SOLID sub-principles from #### to ### level (SRP, OCP, LSP, ISP, DIP) - Add individual ### entries for all 5 test double variants (Dummy, Stub, Spy, Mock, Fake) npm audit (website/): - Run npm audit fix (resolved high-severity lodash/lodash-es vulnerabilities) - Add tmp>=0.2.4 override (fixes GHSA-52f5-9888-hmc6 symlink write in @lhci/cli) - Result: 0 vulnerabilities Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cpoepke
force-pushed
the
fix/posix-sh-and-feynman-grammar
branch
from
74062e5 to
12d34c9
Compare
Fixes GHSA-4w7w-66w2-5vf9, GHSA-v2wj-q39q-566r, GHSA-p9ff-h696-f583 (path traversal in .map handling, server.fs.deny bypass, arbitrary file read via WebSocket dev server). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rdmueller — these findings from your re-review of #203 and a CodeRabbit catalog-sync check were missing and not addressed before #203/#388 merged.
What's fixed
From re-review of #203
🟡 Medium):prompt-onboarding.sh→#!/bin/sh+set -eu(no bash dep, no pipelines in script)🟡 Low): "Explain concept simply" → "Explain concepts simply" in both catalog copiesCatalog sync (
🟠 Major— CodeRabbit check)references/catalog.mdwas missing individual entries for anchors that exist as files indocs/anchors/:####to###level (SRP, OCP, LSP, ISP, DIP)Note: Many other "missing" entries in the CodeRabbit report are slug-comparison false positives — entries that exist in the catalog with parenthetical subtitles (e.g. "Five Whys (Ohno)" vs file slug
five-whys). These are intentional.npm audit (
🔴 HighCI failure)npm audit fix: resolved high-severitylodash/lodash-esvulnerabilities (GHSA-r5fr-rjxr-66jc, GHSA-f23m-r3pf-42rh)tmp>=0.2.4override: fixes GHSA-52f5-9888-hmc6 symlink write in@lhci/clitransitive depTest plan
dash plugins/semantic-anchors/scripts/prompt-onboarding.shexits 0skill/andplugins/catalog copiesnpm audit --audit-level=high→ 0 vulnerabilities🤖 Generated with Claude Code
Summary by CodeRabbit