Skip to content

feat: add SLAP, Occam's Razor, Code Smells anchors (#440, #439, #435)#444

Merged
rdmueller merged 5 commits into
LLM-Coding:mainfrom
raifdmueller:add-slap-occam-code-smells-anchors
Apr 20, 2026
Merged

feat: add SLAP, Occam's Razor, Code Smells anchors (#440, #439, #435)#444
rdmueller merged 5 commits into
LLM-Coding:mainfrom
raifdmueller:add-slap-occam-code-smells-anchors

Conversation

@raifdmueller
Copy link
Copy Markdown
Contributor

@raifdmueller raifdmueller commented Apr 20, 2026

Summary

Adds three new semantic anchors based on community proposals:

All three passed the four anchor quality criteria (Precise, Rich, Consistent, Attributable).

Closes #440, closes #439, closes #435.

Test plan

  • AsciiDoc linter passes on all six new files
  • npm run extract-metadata lists all three anchors in anchors.json (total 134)
  • npm run build succeeds and pre-renders all 9 static routes
  • No stray workflow-* entries in generated data
  • Changelog updated with 2026-04-20 entry crediting each proposer
  • AgentSkill catalog (skill/semantic-anchor-translator/references/catalog.md) updated with all three entries

🤖 Generated with Claude Code

Summary by CodeRabbit

Dokumentation

  • Drei neue Dokumentationsanker eingeführt: Code Smells, Occam's Razor und Single Level of Abstraction Principle (SLAP) mit umfassenden Erklärungen, Anwendungsszenarien und verwandten Konzepten
  • Vollständige Unterstützung für Englisch und Deutsch
  • Integriert in Design-Prinzipien und Problem-Lösungs-Kategorien mit erweiterten Metadaten und verbesserter Auffindbarkeit

raifdmueller and others added 5 commits April 20, 2026 11:41
…ding#440)

Proposed by @eirikbell in LLM-Coding#440. Clean-code function-design rule:
all statements in a function operate at one abstraction level.
Formalises Kent Beck's Composed Method pattern; codified as a
function-design rule in Robert C. Martin's Clean Code.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Proposed by @danielschmeiss in LLM-Coding#439. Epistemic parsimony principle:
among competing hypotheses, prefer the one with fewest assumptions.
Distinct from KISS — Occam applies to explanations (debugging,
diagnosis, architecture rationale), KISS to solutions.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Proposed by @ma7tz in LLM-Coding#435. Surface indications in code that point
to deeper design problems; Fowler's *Refactoring* (1999) catalogue
as primary source, Kent Beck coined the term, Robert C. Martin's
*Clean Code* Appendix A extends the enumeration. Scope broadened
from the original "Code Smells according to Martin" framing to give
Beck/Fowler canonical attribution.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ells

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 4091f735-48eb-4b3b-b3d6-eb817feea7ba

📥 Commits

Reviewing files that changed from the base of the PR and between 234ba58 and ff68d81.

📒 Files selected for processing (12)
  • docs/anchors/code-smells.adoc
  • docs/anchors/code-smells.de.adoc
  • docs/anchors/occams-razor.adoc
  • docs/anchors/occams-razor.de.adoc
  • docs/anchors/single-level-of-abstraction-principle.adoc
  • docs/anchors/single-level-of-abstraction-principle.de.adoc
  • docs/changelog.adoc
  • skill/semantic-anchor-translator/references/catalog.md
  • website/public/data/anchors.json
  • website/public/data/categories.json
  • website/public/data/metadata.json
  • website/public/data/roles.json

Walkthrough

Drei neue semantische Anker werden hinzugefügt: Code Smells, Occam's Razor und Single Level of Abstraction Principle (SLAP). Für jeden Anker werden AsciiDoc-Dokumentationen in Englisch und Deutsch erstellt. Die unterstützenden JSON-Datendateien, das Changelog und der Katalog werden entsprechend aktualisiert.

Änderungen

Kohort / Datei(en) Zusammenfassung
Dokumentations-Anker
docs/anchors/code-smells.adoc, docs/anchors/code-smells.de.adoc, docs/anchors/occams-razor.adoc, docs/anchors/occams-razor.de.adoc, docs/anchors/single-level-of-abstraction-principle.adoc, docs/anchors/single-level-of-abstraction-principle.de.adoc
Sechs neue AsciiDoc-Dokumentationen in Englisch und Deutsch mit Metadaten, definierten Konzepten, Verwendungsrichtlinien und Verknüpfungen zu verwandten Ankern.
Changelog und Katalog
docs/changelog.adoc, skill/semantic-anchor-translator/references/catalog.md
Neue Einträge für die drei Anker mit Quellenangaben und verknüpften Issue-Referenzen sowie Katalogeinträge mit Aliassen und Kernbeschreibungen.
Website-Daten
website/public/data/anchors.json, website/public/data/categories.json, website/public/data/metadata.json, website/public/data/roles.json
JSON-Dateiaktualisierungen: neue Ankereinträge, Kategoriezuordnungen, aktualisierte Zählstände (131→134 Anker) und Rollenzuordnungen für alle drei neuen Anker.

Geschätzter Code-Review-Aufwand

🎯 1 (Trivial) | ⏱️ ~3 Minuten

Möglicherweise verwandte PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Der Titel präzisiert die drei neuen Semantic Anchors (SLAP, Occam's Razor, Code Smells) und referenziert die entsprechenden Issues, was den Kern der Änderungen klar zusammenfasst.
Linked Issues check ✅ Passed Alle Anforderungen aus den verknüpften Issues (#440, #439, #435) sind erfüllt: SLAP mit Bezug zu Composed Method und Clean Code, Occam's Razor als epistemisches Prinzip mit Abgrenzung zu KISS, Code Smells mit Attribution zu Beck, Fowler und Martin.
Out of Scope Changes check ✅ Passed Alle Änderungen sind direkt auf die Hinzufügung der drei Semantic Anchors, deren Dokumentation und die notwendigen Metadaten-Updates begrenzt; keine unrelated Änderungen identifiziert.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rdmueller rdmueller merged commit 4edfaca into LLM-Coding:main Apr 20, 2026
7 of 8 checks passed
rdmueller pushed a commit that referenced this pull request Apr 21, 2026
Picks up the 4 anchors merged in #444 and #445 that the previous PRs
did not regenerate (SLAP, Occam's Razor, Code Smells, WWCND).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants