chore(deps): clear high-severity audit findings (tmp override)#545
Merged
Conversation
npm audit --audit-level=high failed on four high-severity transitive deps of @lhci/cli, all tracing to tmp <0.2.6 (tmp → external-editor → inquirer). The existing override pinned tmp >=0.2.4, which still allowed the vulnerable 0.2.4/0.2.5. Bumping the override to >=0.2.6 resolves tmp to 0.2.7 and clears all high findings. npm's own fix path (audit fix --force) would downgrade @lhci/cli to 0.1.0, a SemVer-major regression — the override avoids that. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughDie Pull Request erhöht die Mindestversion des ChangesAbhängigkeitsverwaltung
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm audit --audit-level=high(the Dependency Security Audit CI job) fails on four high-severity transitive dependencies of@lhci/cli, all tracing totmp <0.2.6:tmp→external-editor→inquirer→@lhci/cliThe existing
overridesalready pinnedtmp >=0.2.4, but the advisory (GHSA for tmp arbitrary file/dir write) coverstmp <0.2.6, so0.2.4/0.2.5were still resolved and still vulnerable.Fix
Raise the override to
tmp >=0.2.6. This resolvestmpto0.2.7and clears all four high findings.npm audit --audit-level=highnow exits 0.npm's own remediation (
npm audit fix --force) would downgrade@lhci/clito0.1.0— a SemVer-major regression that would break Lighthouse CI. The override avoids that.Scope
Only
package.json(override bump) andpackage-lock.json(tmp 0.2.5 → 0.2.7). 7 moderate findings remain; these are below the--audit-level=highgate and out of scope for this PR.Test
npm test— all 90 unit tests pass.🤖 Generated with Claude Code
Summary by CodeRabbit
Versionshinweise