fix(docs): address review on the Anchors and Training Data article#589
Conversation
- main.js: reload the article on language switch (handleLanguageChange was missing a case for /training-data-vs-practice, unlike every other doc route) - router.js: align the browser/tab title with the article's actual title - article: drop the "full fully-dressed" redundancy Addresses CodeRabbit + Copilot review feedback on LLM-Coding#586. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughDie PR ergänzt sprachliche Verbesserungen der Seite ChangesTraining-Data-vs-Practice Seite
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #586, addressing the CodeRabbit + Copilot review.
main.js(real bug, CodeRabbit):handleLanguageChange()had no case for/training-data-vs-practice, so toggling EN/DE on the article did not re-render it, unlike every other doc route. Added the branch (mirrorsharness-inventory).router.js(Copilot): aligned the browser/tab title with the article's actual title (An Anchor Delivers Only as Far as the Prior Reaches) instead of the nav label.Skipped the "&" → "and" nav-label nit — "&" is idiomatic and short in a nav menu.
The cross-model validation (GPT-5 / Gemini) from @JensGrote's review is intentionally not in this PR — he is opening a separate PR for that with his raw data.
🤖 Generated with Claude Code
Summary by CodeRabbit