feat: Criticism sections for remaining 12 contested anchors (batch 3 of #603)#606
Merged
rdmueller merged 1 commit intoJun 11, 2026
Conversation
… 3 (LLM-Coding#603) Completes the Criticism candidates from the LLM-Coding#603 triage. Each section follows the established convention: named critics, fetch-verified linked sources, report-the-discourse tone, alternatives named where the discourse names them. All sources were researched by six parallel agents with mandatory link verification before commit. Anchors: 4MAT, AIDA, Clean Architecture, CQRS, DRY, Freytag's Pyramid, GoF Design Patterns (overview), Hero's Journey, Jobs To Be Done, Kotter's 8-Step Change Model, MVP, Save the Cat. Highlights: the DRY authors' own concession ("a tiny and fairly trivial part"), Norvig's 16-of-23 finding with corrected attribution (Graham's "invisible or simpler" is a paraphrase), the JTBD Christensen-vs-Ulwick two-schools dispute, and Kotter's own Accelerate revision conceding the linearity. Refs LLM-Coding#603 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
WalkthroughTwelve semantic anchor documentation files receive consistent "Criticism" sections across English and German variants, each documenting named critics and linked source references for contested claims, alongside a changelog entry tracking completion of this batch within the ChangesSourced criticism sections batch 3
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/anchors/save-the-cat.de.adoc (1)
1-4:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFehlendes Pflicht-Metadatenattribut
:proponents:.Die German-Version fehlt das erforderliche
:proponents:-Attribut in den Metadaten (Zeilen 1-4). Laut Coding-Guidelines sind:categories:,:roles:und:proponents:Pflichtfelder für alle Semantic-Anchor-Dateien. Die englische Version enthält dieses Attribut in Zeile 5.Hinweis: Dies ist ein bereits existierender Mangel (nicht durch diese PR eingeführt), sollte aber korrigiert werden, da die Datei ohnehin bearbeitet wird.
📋 Vorgeschlagene Ergänzung
= Save the Cat! (15-Beat-Sheet) :categories: creative-writing :roles: technical-writer, educator, consultant +:related: three-act-structure, freytags-pyramid, fichtean-curve +:proponents: Blake Snyder ("Save the Cat! The Last Book on Screenwriting You'll Ever Need") +:tags: storytelling, screenplay, beats, blake-snyder, commercial, plot, structure, save-the-cat, beat-sheet, genre +:tier: 3🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/anchors/save-the-cat.de.adoc` around lines 1 - 4, Add the missing required metadata attribute :proponents: to the top matter of the German "Save the Cat! (15-Beat-Sheet)" anchor so the metadata block contains :categories:, :roles:, and :proponents:; copy or mirror the value used in the English anchor if available (or supply the appropriate proponents list), ensuring the new :proponents: line appears alongside the existing :categories: and :roles: entries in the file header.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/anchors/gof-design-patterns.adoc`:
- Around line 54-56: Die zitierte Paul-Graham-Textstelle "When I see patterns in
my programs, I consider it a sign of trouble" fehlt der abschließende Punkt;
suche die Zeichenkette genau so in der Datei (die Zeile mit dem Zitat) und füge
den Punkt innerhalb der Anführungszeichen hinzu, sodass das Zitat exakt mit
"..." endet; prüfe außerdem benachbarte Vorkommen desselben Zitats und passe sie
konsistent an (siehe auch den Kontextmarker <<gof-singleton-pattern,Singleton>>
zur Lokalisierung).
---
Outside diff comments:
In `@docs/anchors/save-the-cat.de.adoc`:
- Around line 1-4: Add the missing required metadata attribute :proponents: to
the top matter of the German "Save the Cat! (15-Beat-Sheet)" anchor so the
metadata block contains :categories:, :roles:, and :proponents:; copy or mirror
the value used in the English anchor if available (or supply the appropriate
proponents list), ensuring the new :proponents: line appears alongside the
existing :categories: and :roles: entries in the file header.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 3562c6c4-79e2-41db-941a-8d2d580d7846
📒 Files selected for processing (25)
docs/anchors/4mat.adocdocs/anchors/4mat.de.adocdocs/anchors/aida-model.adocdocs/anchors/aida-model.de.adocdocs/anchors/clean-architecture.adocdocs/anchors/clean-architecture.de.adocdocs/anchors/cqrs.adocdocs/anchors/cqrs.de.adocdocs/anchors/dry.adocdocs/anchors/dry.de.adocdocs/anchors/freytags-pyramid.adocdocs/anchors/freytags-pyramid.de.adocdocs/anchors/gof-design-patterns.adocdocs/anchors/gof-design-patterns.de.adocdocs/anchors/heros-journey.adocdocs/anchors/heros-journey.de.adocdocs/anchors/jobs-to-be-done.adocdocs/anchors/jobs-to-be-done.de.adocdocs/anchors/kotter-8-step-change-model.adocdocs/anchors/kotter-8-step-change-model.de.adocdocs/anchors/mvp.adocdocs/anchors/mvp.de.adocdocs/anchors/save-the-cat.adocdocs/anchors/save-the-cat.de.adocdocs/changelog.adoc
Comment on lines
+54
to
+56
| * Peter Norvig, https://norvig.com/design-patterns/["Design Patterns in Dynamic Languages"] (1996/1998) — 16 of the 23 patterns have a "qualitatively simpler implementation" in Lisp or Dylan than in C++, or vanish into the language entirely: many patterns compensate for missing language features rather than capture universal design wisdom | ||
| * Paul Graham, https://www.paulgraham.com/icad.html["Revenge of the Nerds"] (2002) — recurring patterns may be evidence of "the human compiler at work": "When I see patterns in my programs, I consider it a sign of trouble", a sign the language's abstractions are not powerful enough | ||
| * The authors themselves treat the catalog as a 1994 snapshot, not a closed canon: in the https://www.informit.com/articles/article.aspx?p=1404056[2009 InformIT interview] they discuss how they would reorganize and trim it today (see also the Criticism on <<gof-singleton-pattern,Singleton>>) |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Fetch the Paul Graham essay and check for the exact quote
curl -s "https://www.paulgraham.com/icad.html" | grep -i "patterns" | head -20Repository: LLM-Coding/Semantic-Anchors
Length of output: 330
Paul-Graham-Zitat ist in der Quelle wortgetreu vorhanden — Auf https://www.paulgraham.com/icad.html steht der Satz „When I see patterns in my programs, I consider it a sign of trouble“ (im Original mit abschließendem Punkt); in docs/anchors/gof-design-patterns.adoc ggf. die Interpunktion (Punkt am Satzende) innerhalb der Anführungszeichen konsistent übernehmen.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/anchors/gof-design-patterns.adoc` around lines 54 - 56, Die zitierte
Paul-Graham-Textstelle "When I see patterns in my programs, I consider it a sign
of trouble" fehlt der abschließende Punkt; suche die Zeichenkette genau so in
der Datei (die Zeile mit dem Zitat) und füge den Punkt innerhalb der
Anführungszeichen hinzu, sodass das Zitat exakt mit "..." endet; prüfe außerdem
benachbarte Vorkommen desselben Zitats und passe sie konsistent an (siehe auch
den Kontextmarker <<gof-singleton-pattern,Singleton>> zur Lokalisierung).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third batch of the catalog triage in #603 — completes all 23 Criticism candidates (batch 1 did 10, MBTI predates the convention). Twelve anchors get a Criticism section (EN + DE), every claim with a named critic and a fetch-verified linked source. Six parallel research agents, link verification before commit.
Anchors covered
4mataida-modelclean-architecturecqrsdryfreytags-pyramidgof-design-patternsheros-journeyjobs-to-be-donekotter-8-step-change-modelmvpsave-the-catSource hygiene notes
Verification
node scripts/render-docs.js: all 317 fragments render without errorsRefs #603. Remaining from the triage after this: the 14 lower-priority Current Status candidates (table B rest), 6 thin-prior notes (table C), and the About-page lexicon sentence.
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes