Skip to content

fix: enhance WebSocket access token validation method #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linyuchen merged 2 commits into from
Dec 12, 2025
Merged

fix: enhance WebSocket access token validation method #654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3878e94
fix: enhance WebSocket access token validation method
super1207 Dec 12, 2025
372af72
Update src/milky/network/http.ts
linyuchen Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/milky/network/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,15 @@ class MilkyHttpHandler {
// Check access token for WebSocket connection
if (this.config.accessToken) {
const url = new URL(req.url!, `http://${req.headers.host}`)
const inputToken = url.searchParams.get('access_token')

let inputToken = ''
const authHeader = req.headers['authorization']
if (authHeader?.toLowerCase().startsWith('bearer ')) {
inputToken = authHeader.slice(7).trim()
this.ctx.logger.info('receive ws header token', inputToken)
} else {
inputToken = url.searchParams.get('access_token') ?? ''
}
Comment thread
sourcery-ai[bot] marked this conversation as resolved.

if (!inputToken || inputToken !== this.config.accessToken) {
this.ctx.logger.warn('MilkyHttp', `${req.socket.remoteAddress} -> /event (Credentials invalid)`)
Expand Down
Loading