Add missing math and sys imports in llava_trainer.py#505
Open
Mr-Neutr0n wants to merge 1 commit intoLLaVA-VL:mainfrom
Open
Add missing math and sys imports in llava_trainer.py#505Mr-Neutr0n wants to merge 1 commit intoLLaVA-VL:mainfrom
Mr-Neutr0n wants to merge 1 commit intoLLaVA-VL:mainfrom
Conversation
The _inner_training_loop method uses math.ceil() and sys.maxsize but neither module was imported, causing NameError during training. Fixes LLaVA-VL#504
Author
|
hey, just checking in. this adds missing math and sys imports in llava_trainer.py that cause NameError at runtime. one-liner fix |
Author
|
Friendly bump! Let me know if there's anything I should update or improve to help move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import mathandimport systollava/train/llava_trainer.py_inner_training_loopusesmath.ceil()andsys.maxsizebut neither module was importedNameError: name 'math' is not definedRelated Issue
Fixes #504
Test plan