Fix some BigDecimal comparisons

Krakenied · Krakenied · commit ec15cb3eae63 · 2026-04-15T22:39:53.000+02:00
Related to #854 Suggested-by: Cyanoure <kozelka.r@gmail.com>
diff --git a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/EssentialsBalanceTaskType.java b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/EssentialsBalanceTaskType.java
@@ -61,7 +61,7 @@ public void onStart(final @NotNull Quest quest, final @NotNull Task task, final
 
         int earningsNeeded = (int) task.getConfigValue("amount");
         BigDecimal amount = BigDecimal.valueOf(earningsNeeded);
-        if (balance.compareTo(amount) > 0) {
+        if (balance.compareTo(amount) >= 0) {
             super.debug("Marking task as complete", quest.getId(), task.getId(), player.getUniqueId());
             taskProgress.setCompleted(true);
         }
@@ -92,7 +92,7 @@ public void onUserBalanceUpdate(UserBalanceUpdateEvent event) {
 
             int earningsNeeded = (int) task.getConfigValue("amount");
             BigDecimal amount = BigDecimal.valueOf(earningsNeeded);
-            if (balance.compareTo(amount) > 0) {
+            if (balance.compareTo(amount) >= 0) {
                 super.debug("Marking task as complete", quest.getId(), task.getId(), player.getUniqueId());
                 taskProgress.setCompleted(true);
             }
diff --git a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockLevelType.java b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockLevelType.java
@@ -55,7 +55,7 @@ public void onIslandLevel(IslandWorthUpdateEvent event) {
                 taskProgress.setProgress(event.getNewLevel().doubleValue());
                 super.debug("Updating task progress (now " + event.getNewLevel().doubleValue() + ")", quest.getId(), task.getId(), player.getUniqueId());
 
-                if (event.getNewLevel().compareTo(bd) > 0) {
+                if (event.getNewLevel().compareTo(bd) >= 0) {
                     super.debug("Marking task as complete", quest.getId(), task.getId(), player.getUniqueId());
                     taskProgress.setCompleted(true);
                 }
diff --git a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockWorthType.java b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockWorthType.java
@@ -55,7 +55,7 @@ public void onIslandLevel(IslandWorthUpdateEvent event) {
                 taskProgress.setProgress(event.getNewLevel().doubleValue());
                 super.debug("Updating task progress (now " + event.getNewLevel().doubleValue() + ")", quest.getId(), task.getId(), player.getUniqueId());
 
-                if (event.getNewLevel().compareTo(bd) > 0) {
+                if (event.getNewLevel().compareTo(bd) >= 0) {
                     super.debug("Marking task as complete", quest.getId(), task.getId(), player.getUniqueId());
                     taskProgress.setCompleted(true);
                 }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public void onIslandLevel(IslandWorthUpdateEvent event) {`
`55`	`55`	`taskProgress.setProgress(event.getNewLevel().doubleValue());`
`56`	`56`	`super.debug("Updating task progress (now " + event.getNewLevel().doubleValue() + ")", quest.getId(), task.getId(), player.getUniqueId());`
`57`	`57`
`58`		`- if (event.getNewLevel().compareTo(bd) > 0) {`
	`58`	`+ if (event.getNewLevel().compareTo(bd) >= 0) {`
`59`	`59`	`super.debug("Marking task as complete", quest.getId(), task.getId(), player.getUniqueId());`
`60`	`60`	`taskProgress.setCompleted(true);`
`61`	`61`	`}`