Add Sync Loading Support to AscendP2PBackend#236
Draft
matthewygf wants to merge 11 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces synchronous P2P lookup capabilities and enhances the robustness of asynchronous operations within the Ascend P2P backend. Key implementations include a dedicated ZMQ DEALER for synchronous queries with a TTL-based lookup cache, and a patch for the cache controller worker to ensure ZMQ operations are marshaled to the correct event loop. The changes also improve proxy memory management by ensuring resources are released if a proxy is discarded before consumption, and add support for blocking operations like batched_contains and batched_get_blocking. I have no feedback to provide as there were no review comments.
Collaborator
Author
|
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #229 and does the following:
Why