Fix Sndio backend & cleanup compilation on OpenBSD (#8407)

- Resolves #8406 by fixing a sndio backend regression introduced in #7568
- Sets `Qt[5-6]_DIR` and `Qt[5-6]Test_DIR` automatically for OpenBSD, similar to how this is handled for macOS
- Add `$LOCALBASE` and `$X11BASE` to include and link paths when compiling for OpenBSD
- Explicitly disable several features by default when compiling for OpenBSD, as is done in the ports tree

Author: rubiefawn

CMakeLists.txt

@@ -150,6 +150,32 @@ ELSE(LMMS_BUILD_WIN32)
 	SET(STATUS_WINMM "<not supported on this platform>")
 ENDIF(LMMS_BUILD_WIN32)
 
+IF(LMMS_BUILD_OPENBSD)
+	# “don't link deprecated ossaudio on OpenBSD”
+	# https://cvsweb.openbsd.org/checkout/ports/audio/lmms/patches/patch-CMakeLists_txt?rev=1.3
+	SET(WANT_OSS OFF)
+	SET(STATUS_OSS "<not supported on this platform>")
+	# LMMS finds SDL and compiles fine with it enabled, but it doesn't
+	# appear as an option when choosing an audio backend in settings for
+	# some reason. This might be fixable, but the OpenBSD ports
+	# maintainers have also explicitly disabled SDL since 2010-10-28.
+	# https://cvsweb.openbsd.org/checkout/ports/audio/lmms/Makefile?rev=1.1
+	SET(WANT_SDL OFF)
+	SET(STATUS_SDL "<not supported on this platform>")
+	# “explicitly disable pulseaudio in these ports so they won't pick
+	# it up when it becomes available.”
+	# https://cvsweb.openbsd.org/checkout/ports/audio/lmms/Makefile?rev=1.5
+	SET(WANT_PULSEAUDIO OFF)
+	SET(STATUS_PULSEAUDIO "<not supported on this platform>")
+	# OpenBSD does not and never will have WINE, which is necessary for
+	# Windows VST support.
+	# TODO: Is Linux VST support on OpenBSD possible?
+	SET(WANT_VST OFF)
+	SET(STATUS_VST "<not supported on this platform>")
+	SET(STATUS_VST_32 "<not supported on this platform>")
+	SET(STATUS_VST_64 "<not supported on this platform>")
+ENDIF()
+
 SET(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 CHECK_INCLUDE_FILES(pthread.h LMMS_HAVE_PTHREAD_H)
@@ -165,8 +191,6 @@ CHECK_INCLUDE_FILES(sys/soundcard.h LMMS_HAVE_SYS_SOUNDCARD_H)
 CHECK_INCLUDE_FILES(soundcard.h LMMS_HAVE_SOUNDCARD_H)
 CHECK_INCLUDE_FILES(fcntl.h LMMS_HAVE_FCNTL_H)
 CHECK_INCLUDE_FILES(sys/ioctl.h LMMS_HAVE_SYS_IOCTL_H)
-CHECK_INCLUDE_FILES(ctype.h LMMS_HAVE_CTYPE_H)
-CHECK_INCLUDE_FILES(string.h LMMS_HAVE_STRING_H)
 CHECK_INCLUDE_FILES(process.h LMMS_HAVE_PROCESS_H)
 CHECK_INCLUDE_FILES(locale.h LMMS_HAVE_LOCALE_H)
 

cmake/modules/DetectMachine.cmake

@@ -192,3 +192,12 @@ IF(LMMS_BUILD_APPLE)
 	STRING(REGEX REPLACE "\\.[0-9]*$" "" APPLE_OS_VER "${APPLE_OS_VER}")
 	SET(CMAKE_MACOSX_RPATH 1)	
 ENDIF()
+
+IF(LMMS_BUILD_OPENBSD)
+	SET(Qt5_DIR "${OPENBSD_LOCALBASE}/lib/qt5/cmake/Qt5/")
+	SET(Qt5Test_DIR "${OPENBSD_LOCALBASE}/lib/qt5/cmake/Qt5Test/")
+	SET(Qt6_DIR "${OPENBSD_LOCALBASE}/lib/qt6/cmake/Qt6/")
+	SET(Qt6Test_DIR "${OPENBSD_LOCALBASE}/lib/qt6/cmake/Qt6Test/")
+	INCLUDE_DIRECTORIES("${OPENBSD_LOCALBASE}/include/" "${OPENBSD_X11BASE}/include/")
+	LINK_DIRECTORIES("${OPENBSD_LOCALBASE}/lib/" "${OPENBSD_X11BASE}/lib/")
+ENDIF()

doc/Doxyfile.in

@@ -1981,8 +1981,6 @@ PREDEFINED             = "LMMS_BUILD_LINUX=" \
                          "LMMS_HAVE_SOUNDCARD_H=" \
                          "LMMS_HAVE_FCNTL_H=" \
                          "LMMS_HAVE_SYS_IOCTL_H=" \
-                         "LMMS_HAVE_CTYPE_H=" \
-                         "LMMS_HAVE_STRING_H=" \
                          "LMMS_HAVE_PROCESS_H=" \
                          "LMMS_HAVE_LOCALE_H=" \
 

src/core/audio/AudioSndio.cpp

@@ -68,7 +68,8 @@ AudioSndio::AudioSndio(bool& _success_ful, AudioEngine* _audioEngine)
 	sio_initpar(&m_par);
 
 	m_par.pchan = channels();
-	m_par.bits = 16;
+	m_par.bits = sizeof(int_sample_t) * 8;
+	m_par.sig = 1; // int_sample_t must be signed
 	m_par.le = SIO_LE_NATIVE;
 	m_par.rate = sampleRate();
 	m_par.round = audioEngine()->framesPerAudioBuffer();
@@ -130,12 +131,25 @@ void AudioSndio::stopProcessingImpl()
 void AudioSndio::run()
 {
 	const auto framesPerAudioBuffer = audioEngine()->framesPerAudioBuffer();
-	auto buf = std::vector<float>(framesPerAudioBuffer * channels());
+	const auto samplesPerAudioBuffer = framesPerAudioBuffer * channels();
+	auto fbuf = std::vector<sample_t>(samplesPerAudioBuffer);
+	auto ibuf = std::vector<int_sample_t>(samplesPerAudioBuffer);
 
 	while (AudioDevice::isRunning())
 	{
-		audioEngine()->renderNextBuffer({buf.data(), channels(), framesPerAudioBuffer});
-		sio_write(m_hdl, buf.data(), buf.size() * sizeof(float));
+		audioEngine()->renderNextBuffer({fbuf.data(), channels(), framesPerAudioBuffer});
+
+		// Sndio doesn't speak float, so convert samples to signed int.
+		// While convertToS16() exists, it is intentionally not used
+		// here. There is no need to convert endian-ness since sndio was
+		// initialized with SIO_LE_NATIVE, and there's no reason to
+		// also convert to SampleFrame.
+		for (auto i = 0u; i < samplesPerAudioBuffer; ++i)
+		{
+			ibuf[i] = static_cast<int_sample_t>(AudioEngine::clip(fbuf[i]) * OUTPUT_SAMPLE_MULTIPLIER);
+		}
+
+		sio_write(m_hdl, ibuf.data(), ibuf.size() * sizeof(int_sample_t));
 	}
 }
 

src/lmmsconfig.h.in

@@ -52,7 +52,5 @@
 #cmakedefine LMMS_HAVE_SOUNDCARD_H
 #cmakedefine LMMS_HAVE_FCNTL_H
 #cmakedefine LMMS_HAVE_SYS_IOCTL_H
-#cmakedefine LMMS_HAVE_CTYPE_H
-#cmakedefine LMMS_HAVE_STRING_H
 #cmakedefine LMMS_HAVE_PROCESS_H
 #cmakedefine LMMS_HAVE_LOCALE_H