Resolve remaining C++20 TODOs#8326
Merged
rubiefawn merged 3 commits intoLMMS:masterfrom Mar 23, 2026
Merged
Conversation
With a single exception, which is already handled by LMMS#8321
Member
|
In ArrayVector.h, you can also remove the entire - template<typename It, std::enable_if_t<detail::is_input_iterator_v<It>, int> = 0>
+ template<std::input_iterator It> |
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Member
|
Maybe you could also add a note about /**
* A container that stores up to a maximum of `N` elements of type `T` directly
* within itself, rather than separately on the heap. Useful when a dynamically
* resizeable container is needed for use in real-time code. Can be thought of
* as a hybrid between `std::array` and `std::vector`. The interface follows
* that of `std::vector` - see standard C++ documentation.
+ *
+ * TODO C++26: Use std::inplace_vector instead
*/ |
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
messmerd
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the following TODO comments:
include/ArrayVector.h:309: TODO C++20: Usestd::construct_atinclude/ArrayVector.h:365: TODO C++20: Replace withoperator<=>include/ArrayVector.h:378: TODO C++20: Removeinclude/Flags.h:71: TODO C++20:= defaultinclude/Flags.h:72: TODO C++20: RemoveThe TODO in
include/lmms_math.h:326TODO C++20: usestd::formatted_sizehas some compiler support and is handled separately in #8321.There are likely many other places in the codebase that could benefit from C++20 features. This PR is focused on resolving explicit TODO comments only.