Fix tooltip regressions#8359
Open
messmerd wants to merge 11 commits intoLMMS:masterfrom
Open
Conversation
LOMM, Compressor, FreeBoy and other plugins have Knobs with both normal static tooltips (set with setToolTip()) which provide a description of the Knob's function as well as dynamic floating text showing the model's current value. There was a regression causing both of these types of tooltips to be displayed at the same time. This commit fixes it.
bratpeki
reviewed
Apr 20, 2026
bratpeki
reviewed
Apr 20, 2026
bratpeki
reviewed
Apr 20, 2026
bratpeki
reviewed
Apr 20, 2026
bratpeki
reviewed
Apr 20, 2026
bratpeki
reviewed
Apr 20, 2026
bratpeki
approved these changes
Apr 24, 2026
Member
bratpeki
left a comment
bratpeki
left a comment
There was a problem hiding this comment.
Approved for code. Still needs testing.
Contributor
|
I tested this PR and it fixes the 3 regressions listed above, but it introduces a new bug in volume knobs where the context menu shows the value as a percentage but with the dbFS unit: For comparison, this is what it looks like on master: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regressions fixed by this PR:
FaderFor (1), I reworked how static tooltips work in
FloatModelEditorBase. Rather than useQWidget's tooltips, it shadows the tooltip methods fromQWidgetand redirects them to the existingSimpleTextFloat-based system.Supporting both "static" and "dynamic" tooltips required some improvements to keep better track of user interactions with the Knobs. There was an existing
m_buttonPressedboolean, but this was insufficient, so I converted it into a newInteractionTypeenum for keeping track of the user interaction state.See the "Expected Behaviour" section of the bug report for an explanation of how it works now from the user's perspective.
Fixes #8358