Merge pull request #6 from nabertrand/fix_mp3_bitrate

ralph-irving · web-flow · commit 8d71c74c930d · 2025-09-16T11:34:08.000-04:00
Convert xing data to floats when calculating mp3 bitrate
diff --git a/src/mp3.c b/src/mp3.c
@@ -743,7 +743,7 @@ _mp3_parse(PerlIO *infile, char *file, HV *info)
   // Or if we have a Xing header, use it to determine bitrate
   if (!mp3->bitrate && (mp3->xing_frame->xing_frames && mp3->xing_frame->xing_bytes)) {
     float mfs = (float)frame.samplerate / ( frame.mpegID == MPEG2_ID || frame.mpegID == MPEG25_ID ? 72000. : 144000. );
-    mp3->bitrate = ( mp3->xing_frame->xing_bytes / mp3->xing_frame->xing_frames * mfs );
+    mp3->bitrate = ( (float)mp3->xing_frame->xing_bytes / (float)mp3->xing_frame->xing_frames * mfs );
     DEBUG_TRACE("bitrate from Xing header: %d\n", mp3->bitrate);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -743,7 +743,7 @@ _mp3_parse(PerlIO infile, char file, HV *info)`
`743`	`743`	`// Or if we have a Xing header, use it to determine bitrate`
`744`	`744`	`if (!mp3->bitrate && (mp3->xing_frame->xing_frames && mp3->xing_frame->xing_bytes)) {`
`745`	`745`	`float mfs = (float)frame.samplerate / ( frame.mpegID == MPEG2_ID \|\| frame.mpegID == MPEG25_ID ? 72000. : 144000. );`
`746`		`- mp3->bitrate = ( mp3->xing_frame->xing_bytes / mp3->xing_frame->xing_frames * mfs );`
	`746`	`+ mp3->bitrate = ( (float)mp3->xing_frame->xing_bytes / (float)mp3->xing_frame->xing_frames * mfs );`
`747`	`747`	`DEBUG_TRACE("bitrate from Xing header: %d\n", mp3->bitrate);`
`748`	`748`	`}`
`749`	`749`