Can we drop lib/Log/Log4perl/Config/PropertyConfigurator.pm?

[mavit]

File lib/Log/Log4perl/Config/PropertyConfigurator.pm was added in commit 0698608 to correctly escape a regular expression for modern Perl versions. However, upstream Log::Log4perl has included an equivalent change for many years.

Can we bump the minimum Log::Log4perl to 1.37 (released 2012), and drop this file from lib/?

[michaelherger]

Is 1.37 the version where this particular issue is addressed? Any reason why not to go all in and update to the latest 1.57? I quickly skimmed the changelog, and it didn't list anything obviously problematic.

[mavit]

Is 1.37 the version where this particular issue is addressed?

That's right.

Any reason why not to go all in and update to the latest 1.57?

Not that I'm aware of, but I haven't investigated closely or done any testing either.

[michaelherger]

FWIW: pushed a branch with the latest Log4perl: https://github.com/LMS-Community/slimserver/tree/Log4perl. I'm going to run this on my LMS for a while.