fix: 🐛 Fix recommended extension sync, resolving #81 and #87

Author: tristan-morris

vscoffline/sync.py

@@ -119,6 +119,11 @@ def download_update(self, destination):
         if os.path.exists(destfile) and vsc.Utility.hash_file_and_check(destfile, self.sha256hash):
             log.debug(f'Previously downloaded {self}')
         else:
+            # Some old releases (e.g. stable/win32 - Version: 1.83.1) still reference the old CDN and fail the download,
+            # so these are skipped.
+            if self.updateurl.startswith("https://az764295.vo.msecnd.net"):
+                log.info(f"Skipping old version, no longer available {self}")
+                return False
             log.info(f'Downloading {self} to {destfile}')
             result = requests.get(
                 self.updateurl, allow_redirects=True, timeout=vsc.TIMEOUT)
@@ -372,20 +377,20 @@ def __init__(self, insider, prerelease, version, session):
 
     def get_recommendations(self, destination, totalrecommended):
         recommendations = self.search_top_n(totalrecommended)
-        recommended_old = self.get_recommendations_old(destination)
-
-        for extension in recommendations:
-            # If the extension has already been found then prevent it from being collected again when processing the old recommendation list
-            if extension.identity in recommended_old.keys():
-                del recommended_old[extension.identity]
-
-        for packagename in recommended_old:
-            extension = self.search_by_extension_name(packagename)
-            if extension:
-                recommendations.append(extension)
-            else:
-                log.debug(
-                    f'get_recommendations failed finding a recommended extension by name for {packagename}. This extension has likely been removed.')
+        # recommended_old = self.get_recommendations_old(destination)
+
+        # for extension in recommendations:
+        #     # If the extension has already been found then prevent it from being collected again when processing the old recommendation list
+        #     if extension.identity in recommended_old.keys():
+        #         del recommended_old[extension.identity]
+
+        # for packagename in recommended_old:
+        #     extension = self.search_by_extension_name(packagename)
+        #     if extension:
+        #         recommendations.append(extension)
+        #     else:
+        #         log.debug(
+        #             f'get_recommendations failed finding a recommended extension by name for {packagename}. This extension has likely been removed.')
 
         prereleasecount = 0
         for recommendation in recommendations: