Open
Conversation
gennartan
commented
Dec 11, 2025
gennartan
commented
- Improve lifecycle of the node starting client within the node constructor
- Generalize parameter loading into specific function for proper separation between configuration and logic
- Add on_set_parameter_callback to be able to re-configure the NTRIP client at runtime
- add recovery_timer to periodically check the NTRIP state (and restart the client if necessary)
added 7 commits
December 11, 2025 11:10
Using the argument 'autostart=False' available from jazzy, this allows to create the timer without starting it.
Let the destroy logic be called when the ntrip client node is dereferenced. This is done in order to prepare the ROS node to be re-configurable at runtime. In this case, when calling stop, we do not want the node to self destroy.
This separates the parameter loading logic from the client initialization making it easier to update.
So that the ROS node can manage its child attribute at runtime. In particular it can manages the ntrip_client in dedicated callback.
The recovery callback checks the connection status. When the client is disconnected for too long, try to stop the client and restart.
This is useful to detect update of the NTRIP configuration at runtime and automatically reload the NTRIP client when it is the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.