Forbid export * from '...' syntax in local projects. (microsoft#5513)

iclanton · web-flow · commit 3c97b343c279 · 2025-12-18T21:40:32.000-08:00
* Introduce a rule that forbids 'export * from ...' syntax in local projects.

* Fix exports.
diff --git a/apps/lockfile-explorer-web/src/packlets/lfx-shared/index.ts b/apps/lockfile-explorer-web/src/packlets/lfx-shared/index.ts
@@ -1,8 +1,21 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-export * from './IAppContext';
-export * from './IJsonLfxGraph';
-export * from './IJsonLfxWorkspace';
-export * from './LfxGraph';
+export type { IAppContext } from './IAppContext';
+export {
+  LfxGraphEntryKind,
+  LfxDependencyKind,
+  type IJsonPeerDependencyMeta,
+  type IJsonLfxDependency,
+  type IJsonLfxEntry,
+  type IJsonLfxGraph
+} from './IJsonLfxGraph';
+export type { IJsonLfxWorkspaceRushConfig, IJsonLfxWorkspace } from './IJsonLfxWorkspace';
+export {
+  LfxGraph,
+  LfxGraphDependency,
+  LfxGraphEntry,
+  type ILfxGraphDependencyOptions,
+  type ILfxGraphEntryOptions
+} from './LfxGraph';
 export * as lfxGraphSerializer from './lfxGraphSerializer';
diff --git a/apps/rush-mcp-server/src/index.ts b/apps/rush-mcp-server/src/index.ts
@@ -6,7 +6,7 @@
  * @packageDocumentation
  */
 
-export * from './pluginFramework/IRushMcpPlugin';
-export * from './pluginFramework/IRushMcpTool';
+export { type IRushMcpPlugin, type RushMcpPluginFactory } from './pluginFramework/IRushMcpPlugin';
+export type { IRushMcpTool } from './pluginFramework/IRushMcpTool';
 export { type IRegisterToolOptions, RushMcpPluginSession } from './pluginFramework/RushMcpPluginSession';
-export * from './pluginFramework/zodTypes';
+export { CallToolResultSchema, type CallToolResult, type zodModule } from './pluginFramework/zodTypes';
diff --git a/apps/rush-mcp-server/src/tools/index.ts b/apps/rush-mcp-server/src/tools/index.ts
@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-export * from './base.tool';
-export * from './migrate-project.tool';
-export * from './project-details.tool';
-export * from './rush-command-validator.tool';
-export * from './workspace-details';
-export * from './conflict-resolver.tool';
+export { BaseTool, type IBaseToolOptions, type CallToolResult } from './base.tool';
+export { RushMigrateProjectTool } from './migrate-project.tool';
+export { RushProjectDetailsTool } from './project-details.tool';
+export { RushCommandValidatorTool } from './rush-command-validator.tool';
+export { RushWorkspaceDetailsTool } from './workspace-details';
+export { RushConflictResolverTool } from './conflict-resolver.tool';
diff --git a/build-tests-samples/heft-web-rig-library-tutorial/src/index.ts b/build-tests-samples/heft-web-rig-library-tutorial/src/index.ts
@@ -1,4 +1,5 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
+// eslint-disable-next-line no-restricted-syntax
 export * from './ToggleSwitch';
diff --git a/build-tests/api-documenter-test/src/index.ts b/build-tests/api-documenter-test/src/index.ts
@@ -10,7 +10,9 @@
  * @packageDocumentation
  */
 
+// eslint-disable-next-line no-restricted-syntax
 export * from './DocClass1';
+// eslint-disable-next-line no-restricted-syntax
 export * from './DocEnums';
 import type { IDocInterface1, IDocInterface3, SystemEvent } from './DocClass1';
 
diff --git a/common/changes/@rushstack/mcp-server/forbid-export-star_2025-12-19-02-25.json b/common/changes/@rushstack/mcp-server/forbid-export-star_2025-12-19-02-25.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "type": "none",
+      "packageName": "@rushstack/mcp-server"
+    }
+  ],
+  "packageName": "@rushstack/mcp-server",
+  "email": "iclanton@users.noreply.github.com"
+}
diff --git a/common/changes/@rushstack/stream-collator/forbid-export-star_2025-12-19-02-25.json b/common/changes/@rushstack/stream-collator/forbid-export-star_2025-12-19-02-25.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "type": "none",
+      "packageName": "@rushstack/stream-collator"
+    }
+  ],
+  "packageName": "@rushstack/stream-collator",
+  "email": "iclanton@users.noreply.github.com"
+}
diff --git a/common/changes/@rushstack/tree-pattern/forbid-export-star_2025-12-19-02-25.json b/common/changes/@rushstack/tree-pattern/forbid-export-star_2025-12-19-02-25.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "type": "none",
+      "packageName": "@rushstack/tree-pattern"
+    }
+  ],
+  "packageName": "@rushstack/tree-pattern",
+  "email": "iclanton@users.noreply.github.com"
+}
diff --git a/common/changes/@rushstack/webpack-embedded-dependencies-plugin/forbid-export-star_2025-12-19-02-25.json b/common/changes/@rushstack/webpack-embedded-dependencies-plugin/forbid-export-star_2025-12-19-02-25.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "type": "none",
+      "packageName": "@rushstack/webpack-embedded-dependencies-plugin"
+    }
+  ],
+  "packageName": "@rushstack/webpack-embedded-dependencies-plugin",
+  "email": "iclanton@users.noreply.github.com"
+}
diff --git a/common/changes/@rushstack/webpack4-module-minifier-plugin/forbid-export-star_2025-12-19-02-25.json b/common/changes/@rushstack/webpack4-module-minifier-plugin/forbid-export-star_2025-12-19-02-25.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "type": "none",
+      "packageName": "@rushstack/webpack4-module-minifier-plugin"
+    }
+  ],
+  "packageName": "@rushstack/webpack4-module-minifier-plugin",
+  "email": "iclanton@users.noreply.github.com"
+}
diff --git a/common/changes/@rushstack/webpack5-module-minifier-plugin/forbid-export-star_2025-12-19-02-25.json b/common/changes/@rushstack/webpack5-module-minifier-plugin/forbid-export-star_2025-12-19-02-25.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "type": "none",
+      "packageName": "@rushstack/webpack5-module-minifier-plugin"
+    }
+  ],
+  "packageName": "@rushstack/webpack5-module-minifier-plugin",
+  "email": "iclanton@users.noreply.github.com"
+}
diff --git a/libraries/rush-themed-ui/src/index.ts b/libraries/rush-themed-ui/src/index.ts
@@ -13,9 +13,9 @@
  * @packageDocumentation
  */
 
-export * from './components/Button';
-export * from './components/ScrollArea';
-export * from './components/Tabs';
-export * from './components/Checkbox';
-export * from './components/Input';
-export * from './components/Text';
+export { Button, type IButtonProps } from './components/Button';
+export { ScrollArea, type IScrollAreaProps } from './components/ScrollArea';
+export { Tabs, type ITabsItem, type ITabsProps } from './components/Tabs';
+export { Checkbox, type ICheckboxProps } from './components/Checkbox';
+export { Input, type IInputProps } from './components/Input';
+export { Text, type TextType, type ITextProps } from './components/Text';
diff --git a/libraries/stream-collator/src/index.ts b/libraries/stream-collator/src/index.ts
@@ -13,6 +13,6 @@
  * @packageDocumentation
  */
 
-export * from './CollatedTerminal';
-export * from './CollatedWriter';
-export * from './StreamCollator';
+export { CollatedTerminal } from './CollatedTerminal';
+export { CollatedWriter } from './CollatedWriter';
+export { StreamCollator, type IStreamCollatorOptions } from './StreamCollator';
diff --git a/libraries/tree-pattern/src/index.ts b/libraries/tree-pattern/src/index.ts
@@ -7,4 +7,4 @@
  * @packageDocumentation
  */
 
-export * from './TreePattern';
+export { type TreeNode, type ITreePatternCaptureSet, TreePattern } from './TreePattern';
diff --git a/rigs/decoupled-local-node-rig/profiles/default/includes/eslint/flat/profile/_common.js b/rigs/decoupled-local-node-rig/profiles/default/includes/eslint/flat/profile/_common.js
@@ -171,7 +171,16 @@ module.exports = {
           }
         ],
 
-        'import/no-duplicates': 'warn'
+        'import/no-duplicates': 'warn',
+
+        'no-restricted-syntax': [
+          'error',
+          {
+            // Forbid only bare `export * from '...'`
+            selector: 'ExportAllDeclaration[exported=null]',
+            message: "Use explicit named exports instead of `export * from '...'`."
+          }
+        ]
       }
     },
     {
diff --git a/webpack/webpack-embedded-dependencies-plugin/src/index.ts b/webpack/webpack-embedded-dependencies-plugin/src/index.ts
@@ -14,6 +14,12 @@
  */
 
 import EmbeddedDependenciesWebpackPlugin from './EmbeddedDependenciesWebpackPlugin';
-export * from './EmbeddedDependenciesWebpackPlugin';
+
+export type {
+  IPackageData,
+  IEmbeddedDependenciesWebpackPluginOptions,
+  LicenseFileGeneratorFunction,
+  LicenseFileName
+} from './EmbeddedDependenciesWebpackPlugin';
 
 export default EmbeddedDependenciesWebpackPlugin;
diff --git a/webpack/webpack4-module-minifier-plugin/src/index.ts b/webpack/webpack4-module-minifier-plugin/src/index.ts
@@ -1,12 +1,34 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-export * from './Constants';
-export * from './GenerateLicenseFileForAsset';
-export * from './ModuleMinifierPlugin.types';
-export * from './ModuleMinifierPlugin';
-export * from './PortableMinifierIdsPlugin';
-export * from './RehydrateAsset';
+export {
+  MODULE_WRAPPER_PREFIX,
+  MODULE_WRAPPER_SUFFIX,
+  CHUNK_MODULES_TOKEN,
+  STAGE_BEFORE,
+  STAGE_AFTER
+} from './Constants';
+export { generateLicenseFileForAsset } from './GenerateLicenseFileForAsset';
+export type {
+  IRenderedModulePosition,
+  IAssetInfo,
+  IModuleMinifierPluginStats,
+  IAssetStats,
+  IModuleInfo,
+  IExtendedModule,
+  _IWebpackCompilationData,
+  _INormalModuleFactoryModuleData,
+  IAssetMap,
+  IModuleMap,
+  IModuleMinifierPluginOptions,
+  IDehydratedAssets,
+  IPostProcessFragmentContext,
+  IModuleMinifierPluginHooks,
+  _IAcornComment
+} from './ModuleMinifierPlugin.types';
+export { ModuleMinifierPlugin } from './ModuleMinifierPlugin';
+export { PortableMinifierModuleIdsPlugin } from './PortableMinifierIdsPlugin';
+export { rehydrateAsset } from './RehydrateAsset';
 export type {
   ILocalMinifierOptions,
   IMinifierConnection,
diff --git a/webpack/webpack5-module-minifier-plugin/src/index.ts b/webpack/webpack5-module-minifier-plugin/src/index.ts
@@ -1,8 +1,15 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-export * from './Constants';
-export * from './GenerateLicenseFileForAsset';
+export {
+  MODULE_WRAPPER_PREFIX,
+  MODULE_WRAPPER_SUFFIX,
+  CHUNK_MODULE_TOKEN,
+  CHUNK_MODULE_REGEX,
+  STAGE_BEFORE,
+  STAGE_AFTER
+} from './Constants';
+export { generateLicenseFileForAsset } from './GenerateLicenseFileForAsset';
 export type {
   IAssetInfo,
   IAssetMap,
@@ -18,4 +25,4 @@ export type {
   IPostProcessFragmentContext,
   IRenderedModulePosition
 } from './ModuleMinifierPlugin.types';
-export * from './ModuleMinifierPlugin';
+export { ModuleMinifierPlugin } from './ModuleMinifierPlugin';
