Skip to content

Added @Override to 10 execute() methods, all tests pass.#471

Merged
LSantha merged 1 commit into
masterfrom
opencode/issue466-20260606093541
Jun 6, 2026
Merged

Added @Override to 10 execute() methods, all tests pass.#471
LSantha merged 1 commit into
masterfrom
opencode/issue466-20260606093541

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Jun 6, 2026

Copy link
Copy Markdown

All 10 files updated with @Override on execute(). Full test suite passes: 0 failures across all JUnit tests (core, fs, net, shell, blackbox).

Changes:

  • cli/src/commands/org/jnode/command/system/NamespaceCommand.java — line 48
  • cli/src/commands/org/jnode/command/system/MemoryCommand.java — line 51
  • cli/src/commands/org/jnode/command/system/CpuIDCommand.java — line 47
  • cli/src/commands/org/jnode/command/common/ExitCommand.java — line 47
  • cli/src/commands/org/jnode/command/common/TrueCommand.java — line 46
  • cli/src/commands/org/jnode/command/common/FalseCommand.java — line 46
  • cli/src/commands/org/jnode/command/common/EchoCommand.java — line 56
  • cli/src/commands/org/jnode/command/common/UptimeCommand.java — line 48
  • cli/src/commands/org/jnode/command/common/SleepCommand.java — line 52
  • cli/src/commands/org/jnode/command/file/PwdCommand.java — line 43

Closes #466

New%20session%20-%202026-06-06T09%3A35%3A41.170Z
opencode session  |  github run

Co-authored-by: LSantha <LSantha@users.noreply.github.com>
@LSantha

LSantha commented Jun 6, 2026

Copy link
Copy Markdown
Owner

/oc review

@opencode-agent

opencode-agent Bot commented Jun 6, 2026

Copy link
Copy Markdown
Author

Review: Approved. All 10 changes add @Override to public void execute() throws Exception, which correctly overrides AbstractCommand.execute() at shell/src/shell/org/jnode/shell/AbstractCommand.java:188. Clean, minimal, correct — no issues.

New%20session%20-%202026-06-06T13%3A30%3A43.007Z
opencode session  |  github run

@LSantha LSantha merged commit 6f471b0 into master Jun 6, 2026
1 check passed
@LSantha LSantha deleted the opencode/issue466-20260606093541 branch June 6, 2026 13:35
@LSantha

LSantha commented Jun 6, 2026

Copy link
Copy Markdown
Owner

/oc review

@opencode-agent

opencode-agent Bot commented Jun 6, 2026

Copy link
Copy Markdown
Author

fatal: couldn't find remote ref opencode/issue466-20260606093541

opencode session  |  github run

@LSantha LSantha added the agent/failed The agent exhausted its retries without producing a result. label Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent/failed The agent exhausted its retries without producing a result.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add @Override annotation to execute() in 10 small command classes

1 participant