forked from jnode/jnode
-
Notifications
You must be signed in to change notification settings - Fork 0
Remove stale // FIXME comments from shell completion tests #485
Copy link
Copy link
Closed
Labels
agent/doneThe agent finished successfully; PR opened or comment posted.The agent finished successfully; PR opened or comment posted.area/shellshell/ — command framework, built-in commands, bjorne evaluator.shell/ — command framework, built-in commands, bjorne evaluator.kind/choreRefactor, typo sweep, dead-code removal; no behavior change.Refactor, typo sweep, dead-code removal; no behavior change.
Metadata
Metadata
Assignees
Labels
agent/doneThe agent finished successfully; PR opened or comment posted.The agent finished successfully; PR opened or comment posted.area/shellshell/ — command framework, built-in commands, bjorne evaluator.shell/ — command framework, built-in commands, bjorne evaluator.kind/choreRefactor, typo sweep, dead-code removal; no behavior change.Refactor, typo sweep, dead-code removal; no behavior change.
Description
Two shell test files have a bare
// FIXMEcomment immediately above the@Ignoreannotation:shell/src/test/org/jnode/test/shell/CompletionTest.javaline 57shell/src/test/org/jnode/test/shell/DefaultSyntaxCompletionTest.javaline 53The FIXME was the justification for ignoring the test, but it has been stale for years and provides no specific information about what needs fixing.
What to do
Delete the
// FIXMEline in both files. The@Ignoreannotation and the staticCassowary.initEnv()call in setUp are enough context.Why
Dead comment.
@Ignore+ the static initialization are sufficient; the FIXME is just noise.