Skip to content

Commit 1fd9ce4

Browse files
committed
- fixes #1119
-- use 'x-www-form-urlencoded' for POST / PUT only
1 parent 74319a9 commit 1fd9ce4

3 files changed

Lines changed: 13 additions & 9 deletions

File tree

NetLicensingClient/src/main/java/com/labs64/netlicensing/provider/RestProviderJersey.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import javax.ws.rs.client.Client;
1919
import javax.ws.rs.client.ClientBuilder;
2020
import javax.ws.rs.client.Entity;
21+
import javax.ws.rs.client.Invocation.Builder;
2122
import javax.ws.rs.client.WebTarget;
2223
import javax.ws.rs.core.HttpHeaders;
2324
import javax.ws.rs.core.MediaType;
@@ -63,18 +64,21 @@ public <REQ, RES> RestResponse<RES> call(final String httpMethod, final String u
6364
try {
6465
WebTarget target = getTarget(this.basePath);
6566
addAuthHeaders(target, getAuthentication());
66-
67-
final Entity<REQ> requestEntity = Entity.entity(request, MediaType.APPLICATION_FORM_URLENCODED_TYPE);
68-
final Response response;
6967
target = target.path(urlTemplate);
7068
if ((queryParams != null) && (queryParams.size() > 0)) {
7169
for (final String paramKey : queryParams.keySet()) {
7270
target = target.queryParam(paramKey, queryParams.get(paramKey));
7371
}
7472
}
75-
response = target.request(DEFAULT_ACCEPT_TYPES)
76-
.header(HttpHeaders.USER_AGENT, getUserAgent())
77-
.method(httpMethod, requestEntity);
73+
74+
Response response;
75+
Builder builder = target.request(DEFAULT_ACCEPT_TYPES).header(HttpHeaders.USER_AGENT, getUserAgent());
76+
if ("POST".equals(httpMethod) || "PUT".equals(httpMethod)) {
77+
final Entity<REQ> requestEntity = Entity.entity(request, MediaType.APPLICATION_FORM_URLENCODED_TYPE);
78+
response = builder.method(httpMethod, requestEntity);
79+
} else {
80+
response = builder.method(httpMethod);
81+
}
7882

7983
final RestResponse<RES> restResponse = new RestResponse<RES>();
8084
restResponse.setStatusCode(response.getStatus());

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ Maven:
1919
<dependency>
2020
<groupId>com.labs64.netlicensing</groupId>
2121
<artifactId>netlicensing-client</artifactId>
22-
<version>2.3.0</version>
22+
<version>2.3.1</version>
2323
</dependency>
2424
</dependencies>
2525
```
2626
Gradle:
2727
```gradle
2828
dependencies {
29-
compile 'com.labs64.netlicensing:netlicensing-client:2.3.0'
29+
compile 'com.labs64.netlicensing:netlicensing-client:2.3.1'
3030
}
3131
```

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
<project.title>${project.name}</project.title>
7878
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
7979

80-
<java.version>1.6</java.version>
80+
<java.version>1.7</java.version>
8181
<maven.version>3.0.5</maven.version>
8282

8383
<repo.releases.url>OVERRIDE_REPO_URL</repo.releases.url>

0 commit comments

Comments
 (0)