one format for the errors

Author: yushkevich

NetLicensingClient/src/main/java/com/labs64/netlicensing/domain/EntityFactory.java

@@ -203,7 +203,7 @@ public <T> Page<T> createPage(final Netlicensing netlicensing, final Class<T> en
                         try {
                             ((Visitable) entity).accept(new LinkedEntitiesPopulator(linkedEntities));
                         } catch (final Exception e) {
-                            throw new ConversionException("Error processing linked entities", e);
+                            throw new ConversionException("Error processing linked entities.", e);
                         }
                     }
                 }
@@ -216,7 +216,7 @@ public <T> Page<T> createPage(final Netlicensing netlicensing, final Class<T> en
                     netlicensing.getItems().getTotalitems(),
                     netlicensing.getItems().getHasnext());
         } else {
-            throw new WrongResponseFormatException("Service response is not a page response");
+            throw new WrongResponseFormatException("Service response is not a page response.");
         }
     }
 
@@ -233,21 +233,24 @@ private <T> Converter<Item, T> converterFor(final Class<T> entityClass) {
         try {
             converter = (Converter<Item, T>) getConvertersCache().get(entityClass);
         } catch (final ClassCastException e) {
-            throw new RuntimeException("Wrong converter type found for entity class " + entityClass.getCanonicalName());
+            throw new RuntimeException(
+                    "Wrong converter type found for entity class " + entityClass.getCanonicalName() + ".");
         }
         if (converter == null) {
             final Class<?> converterClass = entityToConverterMap.get(entityClass);
             if (converterClass == null) {
                 throw new IllegalArgumentException("No converter is found for entity of class "
-                        + entityClass.getCanonicalName());
+                        + entityClass.getCanonicalName() + ".");
             }
             try {
                 converter = (Converter<Item, T>) converterClass.newInstance();
                 getConvertersCache().put(entityClass, converter);
             } catch (final InstantiationException e) {
-                throw new RuntimeException("Can not instantiate converter of class " + converterClass.getCanonicalName());
+                throw new RuntimeException(
+                        "Can not instantiate converter of class " + converterClass.getCanonicalName() + ".");
             } catch (final IllegalAccessException e) {
-                throw new RuntimeException("Can not instantiate converter of class " + converterClass.getCanonicalName());
+                throw new RuntimeException(
+                        "Can not instantiate converter of class " + converterClass.getCanonicalName() + ".");
             }
         }
         return converter;
@@ -273,7 +276,7 @@ private Item findSuitableItemOfType(final Netlicensing netlicensing, final Class
             }
         }
         throw new WrongResponseFormatException("Service response doesn't contain item of type "
-                + type.getCanonicalName());
+                + type.getCanonicalName() + ".");
     }
 
     /**
@@ -307,7 +310,7 @@ private Class<?> getEntityClassByItemType(final Item item) throws WrongResponseF
                 return entityClass;
             }
         }
-        throw new WrongResponseFormatException("Service response contains unexpected item type " + itemType);
+        throw new WrongResponseFormatException("Service response contains unexpected item type " + itemType + ".");
     }
 
 }

NetLicensingClient/src/main/java/com/labs64/netlicensing/domain/entity/impl/ProductDiscountImpl.java

@@ -118,7 +118,7 @@ public void setStringAmount(final String amount) {
                 setAmountPercent(DatatypeConverter.parseDecimal(amount.substring(0, amount.length() - 1)));
             } catch (final NumberFormatException e) {
                 throw new IllegalArgumentException(
-                        "Format for discount amount in percent is not correct, expected numeric format");
+                        "Format for discount amount in percent is not correct, expected numeric format.");
             }
         } else {
             final Money amountFix = Money.convertPrice(amount, Currency.EUR.value());

NetLicensingClient/src/main/java/com/labs64/netlicensing/domain/vo/Money.java

@@ -58,21 +58,21 @@ public static Money convertPrice(final String rawPrice, final String rawCurrency
                 target.setAmount(DatatypeConverter.parseDecimal(rawPrice));
             } catch (final NumberFormatException e) {
                 throw new IllegalArgumentException("'" + Constants.PRICE
-                        + "' format is not correct, expected '0.00' format");
+                        + "' format is not correct, expected '0.00' format.");
             }
             if (StringUtils.isNotBlank(rawCurrency)) {
                 if (Currency.parseValueSafe(rawCurrency) == null) {
-                    throw new IllegalArgumentException("Unsupported currency!");
+                    throw new IllegalArgumentException("Unsupported currency.");
                 }
                 target.setCurrencyCode(rawCurrency);
             } else {
                 throw new IllegalArgumentException("'" + Constants.PRICE + "' field must be accompanied with the '"
-                        + Constants.CURRENCY + "' field");
+                        + Constants.CURRENCY + "' field.");
             }
         } else { // 'price' is not provided
             if (StringUtils.isNotBlank(rawCurrency)) {
                 throw new IllegalArgumentException("'" + Constants.CURRENCY + "' field can not be used without the '"
-                        + Constants.PRICE + "' field");
+                        + Constants.PRICE + "' field.");
             }
         }
         return target;

NetLicensingClient/src/main/java/com/labs64/netlicensing/provider/RestProviderJersey.java

@@ -101,7 +101,7 @@ public <REQ, RES> RestResponse<RES> call(final String httpMethod, final String u
             restResponse.setEntity(readEntity(response, responseType));
             return restResponse;
         } catch (final RuntimeException e) {
-            throw new RestException("Exception while calling service", e);
+            throw new RestException("Exception while calling service.", e);
         }
     }
 
@@ -175,7 +175,7 @@ private <RES> RES readEntity(final Response response, final Class<RES> responseT
                 }
                 final String body = buffered ? " '" + response.readEntity(String.class) + "' of type '"
                         + response.getMediaType() + "'" : "";
-                throw new RestException("Could not interpret the response body" + body, ex);
+                throw new RestException("Could not interpret the response body" + body + ".", ex);
             }
         }
     }

NetLicensingClient/src/main/java/com/labs64/netlicensing/schema/converter/ItemToEntityBaseConverter.java

@@ -36,7 +36,8 @@ public T convert(final Item source) throws ConversionException {
         final String entityClass = target.getClass().getInterfaces()[0].getSimpleName();
         if (!entityClass.equals(source.getType())) {
             final String sourceType = (source.getType() != null) ? source.getType() : "<null>";
-            throw new ConversionException(String.format("Wrong item type '%s', expected '%s'", sourceType, entityClass));
+            throw new ConversionException(
+                    String.format("Wrong item type '%s', expected '%s'.", sourceType, entityClass));
         }
 
         target.setActive(Boolean.parseBoolean(

NetLicensingClient/src/main/java/com/labs64/netlicensing/schema/converter/ItemToLicenseTypePropertiesConverter.java

@@ -27,7 +27,7 @@ public class ItemToLicenseTypePropertiesConverter implements Converter<Item, Lic
     public LicenseTypeProperties convert(final Item source) throws ConversionException {
         if (!Constants.Utility.LICENSE_TYPE.equals(source.getType())) {
             final String sourceType = (source.getType() != null) ? source.getType() : "<null>";
-            throw new ConversionException(String.format("Wrong item type '%s', expected '%s'", sourceType,
+            throw new ConversionException(String.format("Wrong item type '%s', expected '%s'.", sourceType,
                     Constants.Utility.LICENSE_TYPE));
         }
 

NetLicensingClient/src/main/java/com/labs64/netlicensing/schema/converter/ItemToLicensingModelPropertiesConverter.java

@@ -27,7 +27,7 @@ public class ItemToLicensingModelPropertiesConverter implements Converter<Item,
     public LicensingModelProperties convert(final Item source) throws ConversionException {
         if (!Constants.Utility.LICENSING_MODEL_PROPERTIES.equals(source.getType())) {
             final String sourceType = (source.getType() != null) ? source.getType() : "<null>";
-            throw new ConversionException(String.format("Wrong item type '%s', expected '%s'", sourceType,
+            throw new ConversionException(String.format("Wrong item type '%s', expected '%s'.", sourceType,
                     Constants.Utility.LICENSING_MODEL_PROPERTIES));
         }
 

NetLicensingClient/src/main/java/com/labs64/netlicensing/schema/converter/ItemsToValidationResultConverter.java

@@ -56,7 +56,7 @@ public ValidationResult convert(final Netlicensing source) throws ConversionExce
             }
 
             if (productModuleNumber == null) {
-                throw new ConversionException(String.format("Validation item does not contain property '%s'",
+                throw new ConversionException(String.format("Validation item does not contain property '%s'.",
                         Constants.ProductModule.PRODUCT_MODULE_NUMBER));
             }
 

NetLicensingClient/src/main/java/com/labs64/netlicensing/service/NetLicensingService.java

@@ -212,14 +212,14 @@ public Netlicensing request(final Context context, final String method, final St
             case NO_CONTENT:
                 return null;
             default:
-                throw new RestException(String.format("Unsupported response status code %s: %s",
+                throw new RestException(String.format("Unsupported response status code %s: %s.",
                         status.getStatusCode(), status.getReasonPhrase()));
             }
         } else {
             if (SchemaFunction.hasErrorInfos(response.getEntity())) {
                 throw new ServiceException(status, response.getHeaders(), response.getEntity());
             } else {
-                throw new RestException(String.format("Unknown service error %s: %s", status.getStatusCode(),
+                throw new RestException(String.format("Unknown service error %s: %s.", status.getStatusCode(),
                         status.getReasonPhrase()));
             }
         }
@@ -236,7 +236,7 @@ public Netlicensing request(final Context context, final String method, final St
      */
     private void configure(final RestProvider restProvider, final Context context) throws RestException {
         if (context.getSecurityMode() == null) {
-            throw new RestException("Security mode must be specified");
+            throw new RestException("Security mode must be specified.");
         }
         switch (context.getSecurityMode()) {
         case BASIC_AUTHENTICATION:
@@ -248,7 +248,7 @@ private void configure(final RestProvider restProvider, final Context context) t
         case ANONYMOUS_IDENTIFICATION:
             break;
         default:
-            throw new RestException("Unknown security mode");
+            throw new RestException("Unknown security mode.");
         }
         if (context.containsKey(RestProvider.Configuration.class)) {
             final Object config = context.getObject(RestProvider.Configuration.class);

NetLicensingClient/src/main/java/com/labs64/netlicensing/util/JAXBUtils.java

@@ -37,25 +37,25 @@ public static <T> T readObjectFromString(final String content, final Class<T> ex
 
     public static <T> T readObjectFromInputStream(final InputStream inputStream, final Class<T> expectedType) {
         try {
-            JAXBContext jaxbContext = JAXBContext.newInstance(expectedType);
-            Unmarshaller unmarshaller = jaxbContext.createUnmarshaller();
-            JAXBElement<T> element = unmarshaller.unmarshal(new StreamSource(inputStream), expectedType);
+            final JAXBContext jaxbContext = JAXBContext.newInstance(expectedType);
+            final Unmarshaller unmarshaller = jaxbContext.createUnmarshaller();
+            final JAXBElement<T> element = unmarshaller.unmarshal(new StreamSource(inputStream), expectedType);
             return element.getValue();
         } catch (final JAXBException e) {
-            throw new RuntimeException("Cannot process resource!", e);
+            throw new RuntimeException("Cannot process resource.", e);
         }
     }
 
     public static <T> String xmlEntityToString(final T entity) {
         try {
-            JAXBContext jaxbContext = JAXBContext.newInstance(entity.getClass());
-            Marshaller marshaller = jaxbContext.createMarshaller();
+            final JAXBContext jaxbContext = JAXBContext.newInstance(entity.getClass());
+            final Marshaller marshaller = jaxbContext.createMarshaller();
             marshaller.setProperty(Marshaller.JAXB_FORMATTED_OUTPUT, true);
-            ByteArrayOutputStream out = new ByteArrayOutputStream();
+            final ByteArrayOutputStream out = new ByteArrayOutputStream();
             marshaller.marshal(entity, out);
             return out.toString();
         } catch (final JAXBException e) {
-            throw new RuntimeException("Cannot convert object to string !", e);
+            throw new RuntimeException("Cannot convert object to string.", e);
         }
     }