Merge pull request #596 from MarvyNwaokobia/fix/frontend-issues-560-561-562-563

Author: ogazboiz

frontend/src/app/activity/page.tsx

@@ -32,7 +32,7 @@ export default function ActivityPage() {
   const [hasMore, setHasMore] = useState(true);
 
   const fetchActivity = useCallback(
-    async (pageNum: number, tab: string, append: boolean = false) => {
+    async (pageNum: number, tab: string, append: boolean = false, signal?: AbortSignal) => {
       if (!session?.publicKey) return;
       setLoading(true);
 
@@ -43,7 +43,7 @@ export default function ActivityPage() {
           `${API_BASE_URL}/v1/events?address=${encodeURIComponent(session.publicKey)}` +
           `&page=${pageNum}&limit=${PAGE_SIZE}${typeQuery}`;
 
-        const response = await fetch(url);
+        const response = await fetch(url, { signal });
         if (!response.ok) {
           throw new Error(`Failed to fetch activity (${response.status})`);
         }
@@ -62,6 +62,7 @@ export default function ActivityPage() {
           setHasMore(next.length === PAGE_SIZE);
         }
       } catch (error) {
+        if (error instanceof DOMException && error.name === "AbortError") return;
         console.error("Failed to fetch activity:", error);
         if (!append) setEvents([]);
         setHasMore(false);
@@ -73,10 +74,11 @@ export default function ActivityPage() {
   );
 
   useEffect(() => {
-    if (status === "connected") {
-      setPage(1);
-      fetchActivity(1, activeTab, false);
-    }
+    if (status !== "connected") return;
+    const controller = new AbortController();
+    setPage(1);
+    fetchActivity(1, activeTab, false, controller.signal);
+    return () => controller.abort();
   }, [activeTab, status, fetchActivity]);
 
   const loadMore = () => {

frontend/src/components/Navbar.tsx

@@ -52,9 +52,6 @@ export const Navbar = () => {
         {status === "connected" && session?.publicKey && (
           <NotificationDropdown publicKey={session.publicKey} />
         )}
-        <Button variant="ghost" className="hidden sm:inline-flex">
-          Log In
-        </Button>
         <WalletButton />
       </div>
     </nav>

frontend/src/components/NotificationDropdown.tsx

@@ -1,5 +1,6 @@
 "use client";
 import React, { useState, useEffect, useCallback } from 'react';
+import { useRouter } from 'next/navigation';
 import { useStreamEvents } from '@/hooks/useStreamEvents';
 import { formatAmount } from '@/utils/amount';
 import { Button } from './ui/Button';
@@ -18,6 +19,7 @@ interface NotificationItem {
 }
 
 export const NotificationDropdown: React.FC<NotificationDropdownProps> = ({ publicKey }) => {
+    const router = useRouter();
     const [isOpen, setIsOpen] = useState(false);
     const [notifications, setNotifications] = useState<NotificationItem[]>([]);
     const [unreadCount, setUnreadCount] = useState(0);
@@ -165,7 +167,8 @@ export const NotificationDropdown: React.FC<NotificationDropdownProps> = ({ publ
                             size="sm"
                             className="w-full text-xs"
                             onClick={() => {
-                                window.location.href = '/activity';
+                                setIsOpen(false);
+                                router.push('/activity');
                             }}
                         >
                             View All Activity

frontend/src/components/dashboard/ActivityHistory.tsx

@@ -154,6 +154,7 @@ export const ActivityHistory: React.FC<ActivityHistoryProps> = ({
                   <a
                     href={`https://stellar.expert/explorer/testnet/tx/${event.transactionHash}`}
                     target="_blank"
+                    rel="noopener noreferrer"
                     className="text-slate-500 hover:text-white transition-colors"
                     title="View on Explorer"
                   >