Fix docs, cache classes of JavaScript functions

Author: juliarn

ultralight-java-databind/src/main/java/com/labymedia/ultralight/databind/DatabindConfiguration.java

@@ -43,9 +43,11 @@ public final class DatabindConfiguration {
      *
      * @param classCache             The class cache used by this configuration
      * @param methodChooser          The method chooser used by this configuration
-     * @param propertyCallerFactory  The factory creating the property caller used for calling properties on java objects and classes
+     * @param propertyCallerFactory  The factory creating the property caller used for calling properties on
+     *                               java objects and classes
      * @param automaticPrototype     If {@code true}, automatic prototyping is enabled
      * @param contextProviderFactory The factory for binding context providers, or {@code null}, if this feature
+     *                               is not required
      */
     private DatabindConfiguration(
             JavascriptClassCache classCache,
@@ -198,7 +200,8 @@ public Builder contextProviderFactory(ContextProviderFactory contextProviderFact
          * @return The built {@link DatabindConfiguration}
          */
         public DatabindConfiguration build() {
-            return new DatabindConfiguration(classCache, methodChooser, propertyCallerFactory, automaticPrototype, contextProviderFactory);
+            return new DatabindConfiguration(
+                    classCache, methodChooser, propertyCallerFactory, automaticPrototype, contextProviderFactory);
         }
     }
 }

ultralight-java-databind/src/main/java/com/labymedia/ultralight/databind/DatabindJavascriptClass.java

@@ -63,6 +63,8 @@ public final class DatabindJavascriptClass {
     private final Map<String, Set<Method>> methods = new HashMap<>();
     private final Map<String, Field> fields = new HashMap<>();
 
+    private final Map<String, JavascriptClass> methodClassCache = new HashMap<>();
+
     /**
      * Constructs a new {@link DatabindJavascriptClass}.
      *
@@ -242,12 +244,13 @@ private JavascriptValue onGetProperty(
         }
 
         return context.makeObject(
-                DatabindJavascriptMethodHandler.create(
+                // caching classes of methods to avoid creating a new class on every call
+                methodClassCache.computeIfAbsent(propertyName, key -> DatabindJavascriptMethodHandler.create(
                         configuration,
                         conversionUtils,
                         propertyCaller,
                         methodSet,
-                        propertyName).bake(),
+                        propertyName).bake()),
                 new DatabindJavascriptMethodHandler.Data(privateData.instance, null));
     }
 

ultralight-java-databind/src/main/java/com/labymedia/ultralight/databind/DatabindJavascriptMethodHandler.java

@@ -119,14 +119,14 @@ private JavascriptValue onCallAsFunction(
                 arguments
         );
 
-        Object ret = this.propertyCaller.callMethod(privateData.instance(), method, parameters.toArray());
+        // Invoke method with constructed arguments
+        Object ret = propertyCaller.callMethod(privateData.instance(), method, parameters.toArray());
         Class<?> suggestedReturnType = method.getReturnType();
 
         if (ret != null) {
             suggestedReturnType = ret.getClass();
         }
 
-        // Invoke method with constructed arguments
         return conversionUtils.toJavascript(context, ret, suggestedReturnType);
     }
 

ultralight-java-databind/src/main/java/com/labymedia/ultralight/databind/call/property/PropertyCaller.java

@@ -33,10 +33,10 @@ public interface PropertyCaller {
     /**
      * Calls a method on a certain instance.
      *
-     * @param instance   The instance the method belongs to or {@code null}, if static
+     * @param instance   The instance the method belongs to, or {@code null}, if static
      * @param method     The method which should be called
      * @param parameters The parameters the method should be called with
-     * @return The return value of the method or {@code null} if void
+     * @return The return value of the method, or {@code null}, if void
      * @throws JavascriptInteropException If an error occurred while calling the method
      */
     Object callMethod(Object instance, Method method, Object[] parameters) throws JavascriptInteropException;
@@ -54,7 +54,7 @@ public interface PropertyCaller {
     /**
      * Returns the value from a certain field.
      *
-     * @param instance The instance the field belongs to or {@code null} if static
+     * @param instance The instance the field belongs to, or {@code null}, if static
      * @param field    The field whose value should be returned
      * @return The value of the field
      * @throws JavascriptInteropException If an error occurred while getting the value from the field
@@ -64,7 +64,7 @@ public interface PropertyCaller {
     /**
      * Sets a value of a certain field.
      *
-     * @param instance The instance the field belongs to or {@code null} if static
+     * @param instance The instance the field belongs to, or {@code null}, if static
      * @param field    The field whose value should be set
      * @param value    The value to be set
      * @throws JavascriptInteropException If an error occurred while setting the value of the field