New Crowdin updates#32
Conversation
WalkthroughThis update expands localization support across multiple languages by adding three new string resources to each language's resource dictionary: Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 44
🧹 Nitpick comments (9)
source/Localization/pt_BR.xaml (1)
4-4: Consider translating "Flag" to PortugueseThe new string resource
LOCCheckLocalizationsFlagis currently in English. Since this is the Brazilian Portuguese localization file, consider translating it to Portuguese (e.g., "Bandeira") for consistency.source/Localization/ru_RU.xaml (1)
4-4: Consider translating "Flag" to RussianThe new string resource
LOCCheckLocalizationsFlagis currently in English. Since this is the Russian localization file, consider translating it to Russian (e.g., "Флаг") for consistency.source/Localization/de_DE.xaml (1)
4-4: Consider translating "Flag" to GermanThe new string resource
LOCCheckLocalizationsFlagis currently in English. Since this is the German localization file, consider translating it to German (e.g., "Flagge" or "Markierung") for consistency.source/Localization/tr_TR.xaml (1)
4-4: Consider translating "Flag" to TurkishThe new string resource
LOCCheckLocalizationsFlagis currently in English. Since this is the Turkish localization file, consider translating it to Turkish (e.g., "Bayrak") for consistency.source/Localization/zh_CN.xaml (5)
16-16: Refine translation forLOCCheckLocalizationsAddNewLanguage.Current:
<sys:String x:Key="LOCCheckLocalizationsAddNewLanguage">添加支持的新语言</sys:String>Suggested wording:
- 添加支持的新语言 + 添加新的支持语言This reads more naturally in Simplified Chinese.
22-22: Refine translation forLOCCheckLocalizationsIntegrationListLanguages.Current:
<sys:String x:Key="LOCCheckLocalizationsIntegrationListLanguages">使用可用语言显示列表</sys:String>Suggested wording:
- 使用可用语言显示列表 + 显示可用语言列表
24-24: Refine translation forLOCCheckLocalizationsIntegrationFlags.Current:
<sys:String x:Key="LOCCheckLocalizationsIntegrationFlags">显示可用的语言标识列表</sys:String>Suggested wording:
- 显示可用的语言标识列表 + 显示可用语言标识列表
26-26: Refine translation forLOCCheckLocalizationsOnlyDisplayExistingFlags.Current:
<sys:String x:Key="LOCCheckLocalizationsOnlyDisplayExistingFlags">只显示已知标志</sys:String>Suggested wording:
- 只显示已知标志 + 只显示已知的标志
32-32: Format parentheses to full-width for Chinese text.Current:
<sys:String x:Key="LOCCheckLocalizationAddTagAudioDescription">带有选定语言的标签 (仅音频)</sys:String>Suggested:
- 带有选定语言的标签 (仅音频) + 带有选定语言的标签(仅音频)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (37)
source/Localization/ar_SA.xaml(2 hunks)source/Localization/bg_BG.xaml(2 hunks)source/Localization/ca_ES.xaml(1 hunks)source/Localization/cs_CZ.xaml(2 hunks)source/Localization/da_DK.xaml(2 hunks)source/Localization/de_DE.xaml(2 hunks)source/Localization/el_GR.xaml(1 hunks)source/Localization/en_US.xaml(3 hunks)source/Localization/es_ES.xaml(2 hunks)source/Localization/et_EE.xaml(2 hunks)source/Localization/fa_IR.xaml(2 hunks)source/Localization/fi_FI.xaml(2 hunks)source/Localization/fr_FR.xaml(2 hunks)source/Localization/gl_ES.xaml(2 hunks)source/Localization/he_IL.xaml(2 hunks)source/Localization/hr_HR.xaml(2 hunks)source/Localization/hu_HU.xaml(2 hunks)source/Localization/id_ID.xaml(2 hunks)source/Localization/it_IT.xaml(2 hunks)source/Localization/ja_JP.xaml(2 hunks)source/Localization/ko_KR.xaml(2 hunks)source/Localization/lt_LT.xaml(2 hunks)source/Localization/nl_NL.xaml(2 hunks)source/Localization/no_NO.xaml(2 hunks)source/Localization/pl_PL.xaml(2 hunks)source/Localization/pt_BR.xaml(2 hunks)source/Localization/pt_PT.xaml(2 hunks)source/Localization/ro_RO.xaml(2 hunks)source/Localization/ru_RU.xaml(2 hunks)source/Localization/sk_SK.xaml(2 hunks)source/Localization/sr_SP.xaml(2 hunks)source/Localization/sv_SE.xaml(2 hunks)source/Localization/tr_TR.xaml(2 hunks)source/Localization/uk_UA.xaml(2 hunks)source/Localization/vi_VN.xaml(2 hunks)source/Localization/zh_CN.xaml(1 hunks)source/Localization/zh_TW.xaml(3 hunks)
🔇 Additional comments (54)
source/Localization/no_NO.xaml (2)
4-4: AddLOCCheckLocalizationsFlagstring resource
This new key aligns with the PR objective to display language flags. The placeholder value is in English; please ensure a proper Norwegian translation is supplied before release.
35-36: Introduce manual-entry update localization keys
KeysLOCCheckLocalizationUpdateWhenHasManualandLOCCheckLocalizationAddedSimilarWhenManualmatch other locales’ additions. Confirm that localized Norwegian text is provided for these entries.source/Localization/sv_SE.xaml (2)
4-4: AddLOCCheckLocalizationsFlagstring resource
New key added for flag support. Placeholder “Flag” should be updated to the correct Swedish term (“Flagga”) by translators.
35-36: Introduce manual-entry update localization keys
New keys for enabling plugin-data updates when manual entries exist. Ensure Swedish translations are applied to these English placeholders.source/Localization/et_EE.xaml (2)
4-4: AddLOCCheckLocalizationsFlagstring resource
Inserted placeholder “Flag” for future translation into Estonian. Please provide the correct localized term (“Lipp”).
35-36: Introduce manual-entry update localization keys
KeysLOCCheckLocalizationUpdateWhenHasManualandLOCCheckLocalizationAddedSimilarWhenManualhave been added. Confirm Estonian translations replace these English placeholders.source/Localization/sr_SP.xaml (2)
4-4: AddLOCCheckLocalizationsFlagstring resource
New key for flag display; placeholder “Flag” should be translated into Serbian (“Застава” or “Zastava”).
35-36: Introduce manual-entry update localization keys
New entries for manual-data update and similarity behavior. Ensure Serbian translations are provided for these English placeholders.source/Localization/sk_SK.xaml (2)
4-4: AddLOCCheckLocalizationsFlagstring resource
Added placeholder “Flag” for Slovak; please update to the correct Slovak translation (“Vlajka”).
35-36: Introduce manual-entry update localization keys
Keys for manual-entry update support added. Remember to replace the English placeholders with Slovak translations.source/Localization/da_DK.xaml (1)
4-4: Danish translation for 'Flag' is correct.
The value "Flag" matches the Danish term for a flag. No changes needed.source/Localization/en_US.xaml (3)
4-4: New key addition for US English is correct.
TheLOCCheckLocalizationsFlagentry with value "Flag" is appropriate for the English resource file.
26-26: Refined English text for flag display.
Changing the value to "Only display existing flags" improves clarity over "Show only known flags".
35-36: New English localization keys added correctly.
The entries forLOCCheckLocalizationUpdateWhenHasManualandLOCCheckLocalizationAddedSimilarWhenManualare present with appropriate English values.source/Localization/ca_ES.xaml (7)
9-12: Catalan translations for main view keys look accurate.
The entriesLOCCheckLocalizationsLocalizations("Idiomes"),LOCCheckLocalizationsGameMenuPluginView("Comprova idiomes"), andLOCCheckLocalizationsGameMenuAddLanguage("Editar manualment un idioma suportat") correctly reflect the UI intents.
16-16: Translation for 'Add a new supported language' is correct.
The Catalan entry "Afegir un nou idioma suportat" is clear and accurate.
20-25: Catalan translations for settings view keys are well done.
Entries such as "Estil de la interfície" and the list display options are consistently and accurately translated.
28-29: Progress bar text translation is correct.
The Catalan strings for progress display ("Idiomes del joc: trobats {0} - no trobats {1}" and "Processant, si us plau, espereu...") are appropriate.
31-33: Tagging descriptions and native indicator translations are accurate.
The entries forLOCCheckLocalizationAddTagDescription,LOCCheckLocalizationAddTagAudioDescription, andLOCCheckLocalizationIsNativeare correctly localized.
40-41: Catalan translations for advanced support buttons are accurate.
The entries "Idioma nadiu" and "Idioma suportat" correctly convey the intended functionality.
43-46: UI labels translations are consistent and clear.
The entries for "Idioma", "Interfície", "Àudio", and "Subtítols" are correctly localized.source/Localization/el_GR.xaml (3)
4-4: Added new localization key for flagsThe new key
LOCCheckLocalizationsFlaghas been added with the English value "Flag" instead of a Greek translation.Consider translating this value to Greek for consistency with other translated strings in this file.
8-47: Greek translations added for multiple localization keysThe previously untranslated UI elements now have proper Greek translations, which improves the localization coverage of the application.
35-36: New localization keys need translationThese two new keys related to plugin data management are added with English values instead of Greek translations.
Consider translating these values to Greek to maintain full localization coverage:
LOCCheckLocalizationUpdateWhenHasManualLOCCheckLocalizationAddedSimilarWhenManualsource/Localization/ja_JP.xaml (4)
4-4: Added new localization key for flagsThe new key
LOCCheckLocalizationsFlaghas been added with the English value "Flag" instead of a Japanese translation.Consider translating this value to Japanese for consistency with other translated strings in this file.
26-26: Updated Japanese translationThe string for displaying known flags has been properly translated to Japanese, which improves the user experience for Japanese users.
32-32: Updated Japanese translation for audio taggingThe audio-only tag description is now properly translated to Japanese, which enhances the localization quality.
35-36: New localization keys need translationThese two new keys related to plugin data management are added with English values instead of Japanese translations.
Consider translating these values to Japanese to maintain full localization coverage:
LOCCheckLocalizationUpdateWhenHasManualLOCCheckLocalizationAddedSimilarWhenManualsource/Localization/it_IT.xaml (4)
4-4: Added new localization key for flagsThe new key
LOCCheckLocalizationsFlaghas been added with the English value "Flag" instead of an Italian translation.Consider translating this value to Italian for consistency with other translated strings in this file.
26-26: Updated Italian translationThe string for displaying known flags has been properly translated to Italian, which improves the user experience for Italian users.
32-32: Updated Italian translation for audio taggingThe audio-only tag description is now properly translated to Italian, which enhances the localization quality.
35-36: New localization keys need translationThese two new keys related to plugin data management are added with English values instead of Italian translations.
Consider translating these values to Italian to maintain full localization coverage:
LOCCheckLocalizationUpdateWhenHasManualLOCCheckLocalizationAddedSimilarWhenManualsource/Localization/es_ES.xaml (4)
4-4: Added new localization key for flagsThe new key
LOCCheckLocalizationsFlaghas been added with the English value "Flag" instead of a Spanish translation.Consider translating this value to Spanish for consistency with other translated strings in this file. The Spanish word would be "Bandera".
26-26: Updated Spanish translationThe string for displaying known flags has been properly translated to Spanish, which improves the user experience for Spanish users.
32-32: Updated Spanish translation for audio taggingThe audio-only tag description is now properly translated to Spanish, which enhances the localization quality.
35-36: New localization keys need translationThese two new keys related to plugin data management are added with English values instead of Spanish translations.
Consider translating these values to Spanish to maintain full localization coverage:
LOCCheckLocalizationUpdateWhenHasManualLOCCheckLocalizationAddedSimilarWhenManualsource/Localization/pt_BR.xaml (2)
26-26: Good localization of flag display settingThe translation of "Show only known flags" to "Mostrar apenas bandeiras conhecidas" is accurate and maintains consistency with the UI style.
32-32: Good translation of audio tag descriptionThe translation "Tag do(s) idioma(s) selecionado(s) (somente áudio)" appropriately includes plural forms with parentheses and maintains the audio-specific context.
source/Localization/ru_RU.xaml (2)
26-26: Good localization of flag display settingThe translation of "Show only known flags" to "Показать только известные флаги" is accurate and maintains consistency with the UI style.
32-32: Good translation of audio tag descriptionThe translation "Метка с выбранными языками (только аудио)" correctly captures the meaning while maintaining proper Russian grammar.
source/Localization/de_DE.xaml (2)
26-26: Good localization of flag display settingThe translation of "Show only known flags" to "Nur bekannte Markierungen anzeigen" is accurate and maintains consistency with the UI style. Using "Markierungen" is consistent with the terminology choice used elsewhere in the file.
32-32: Good translation of audio tag descriptionThe translation "Tag mit ausgewählter Sprache(n) markieren (nur Audio)" appropriately uses German terminology and includes the plural form notation.
source/Localization/tr_TR.xaml (2)
12-12: Good grammatical improvementsThe changes to both strings improve the grammatical correctness in Turkish by changing the imperative form from plural ("düzenleyin", "ekleyin") to singular ("düzenle", "ekle"), which is more natural in this context.
Also applies to: 16-16
31-32: Good plural form adjustmentsThe changes to include "(ler)" in "dil(ler)" appropriately handle both singular and plural cases in Turkish, making the translations more accurate and flexible.
source/Localization/zh_TW.xaml (6)
20-20: Translation correct forLOCCheckLocalizationsStyleUI.
The Traditional Chinese "介面樣式" accurately reflects "Interface style".
29-29: Translation correct forLOCCheckLocalizationsProgressBarTag.
"處理中,請稍候..." properly conveys "Processing, please wait...".
40-40: Translation correct forLOCCheckLocalizationsBtAdvancedSupportNative.
"母語" accurately reflects "Native language".
43-43: Translation correct forLOCCheckLocalizationsLanguage.
"語言" is the appropriate translation.
45-45: Translation correct forLOCCheckLocalizationsAudio.
"音頻" properly conveys "Audio".
47-47: Translation correct forLOCCheckLocalizationsNotes.
"備註" is the correct Traditional Chinese term.source/Localization/zh_CN.xaml (4)
12-12: Translation correct forLOCCheckLocalizationsGameMenuAddLanguage.
"手动编辑支持的语言" accurately conveys "Edit manually a supported language".
41-41: Translation correct forLOCCheckLocalizationsBtAdvancedSupportLanguages.
"支持的语言" accurately reflects "Supported language".
43-43: Translation correct forLOCCheckLocalizationsLanguage.
"语言" is the appropriate term.
47-47: Translation correct forLOCCheckLocalizationsNotes.
"备注" properly conveys "Notes".
| <?xml version="1.0"?> | ||
| <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:sys="clr-namespace:System;assembly=mscorlib"> | ||
|
|
||
| <sys:String x:Key="LOCCheckLocalizationsFlag">Flag</sys:String> |
There was a problem hiding this comment.
Missing Polish translations for new localization entries
The newly added entries are placeholder English text. Please replace with proper Polish translations for the following keys:
- LOCCheckLocalizationsFlag
- LOCCheckLocalizationUpdateWhenHasManual
- LOCCheckLocalizationAddedSimilarWhenManual
Also applies to: 35-36
| <?xml version="1.0"?> | ||
| <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:sys="clr-namespace:System;assembly=mscorlib"> | ||
|
|
||
| <sys:String x:Key="LOCCheckLocalizationsFlag">Flag</sys:String> |
There was a problem hiding this comment.
Missing Hebrew translations for new localization entries
The new entries are currently in English. Please provide accurate Hebrew translations for:
- LOCCheckLocalizationsFlag
- LOCCheckLocalizationUpdateWhenHasManual
- LOCCheckLocalizationAddedSimilarWhenManual
Also applies to: 35-36
| <?xml version="1.0"?> | ||
| <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:sys="clr-namespace:System;assembly=mscorlib"> | ||
|
|
||
| <sys:String x:Key="LOCCheckLocalizationsFlag">Flag</sys:String> |
There was a problem hiding this comment.
Missing Ukrainian translations for new localization entries
The inserted values are in English placeholders. Translate these into Ukrainian for:
- LOCCheckLocalizationsFlag
- LOCCheckLocalizationUpdateWhenHasManual
- LOCCheckLocalizationAddedSimilarWhenManual
Also applies to: 35-36
| <?xml version="1.0"?> | ||
| <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:sys="clr-namespace:System;assembly=mscorlib"> | ||
|
|
||
| <sys:String x:Key="LOCCheckLocalizationsFlag">Flag</sys:String> |
There was a problem hiding this comment.
Missing Arabic translations for new localization entries
The added entries remain in English. Please localize the following keys into Arabic:
- LOCCheckLocalizationsFlag
- LOCCheckLocalizationUpdateWhenHasManual
- LOCCheckLocalizationAddedSimilarWhenManual
Also applies to: 35-36
| <?xml version="1.0"?> | ||
| <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:sys="clr-namespace:System;assembly=mscorlib"> | ||
|
|
||
| <sys:String x:Key="LOCCheckLocalizationsFlag">Flag</sys:String> |
There was a problem hiding this comment.
Missing Korean translations for new localization entries
The values for the new keys are in English placeholders. Provide the correct Korean translations for:
- LOCCheckLocalizationsFlag
- LOCCheckLocalizationUpdateWhenHasManual
- LOCCheckLocalizationAddedSimilarWhenManual
Also applies to: 35-36
| <?xml version="1.0"?> | ||
| <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:sys="clr-namespace:System;assembly=mscorlib"> | ||
|
|
||
| <sys:String x:Key="LOCCheckLocalizationsFlag">Flag</sys:String> |
There was a problem hiding this comment.
Missing Simplified Chinese translation for LOCCheckLocalizationsFlag.
The value is currently "Flag" in English. Please translate it to Simplified Chinese (e.g., "旗帜" or "国旗") to complete localization.
| <?xml version="1.0"?> | ||
| <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:sys="clr-namespace:System;assembly=mscorlib"> | ||
|
|
||
| <sys:String x:Key="LOCCheckLocalizationsFlag">Flag</sys:String> |
There was a problem hiding this comment.
Missing Croatian translation for LOCCheckLocalizationsFlag.
The value is currently "Flag" in English. Please provide the Croatian term (e.g., "Zastava") for this key.
| <sys:String x:Key="LOCCheckLocalizationUpdateWhenHasManual">Can update plugin data when there are manual entries</sys:String> | ||
| <sys:String x:Key="LOCCheckLocalizationAddedSimilarWhenManual">Can have plugin data with the same language entered manually</sys:String> |
There was a problem hiding this comment.
Missing Croatian translations for new localization-check keys.
Both keys are added with English values:
LOCCheckLocalizationUpdateWhenHasManualLOCCheckLocalizationAddedSimilarWhenManual
Please translate them into Croatian. For example:
<sys:String x:Key="LOCCheckLocalizationUpdateWhenHasManual">Može ažurirati podatke dodatka kada postoje ručni unosi</sys:String>
<sys:String x:Key="LOCCheckLocalizationAddedSimilarWhenManual">Može imati podatke dodatka s istim jezikom unesenim ručno</sys:String>| <sys:String x:Key="LOCCheckLocalizationUpdateWhenHasManual">Can update plugin data when there are manual entries</sys:String> | ||
| <sys:String x:Key="LOCCheckLocalizationAddedSimilarWhenManual">Can have plugin data with the same language entered manually</sys:String> |
There was a problem hiding this comment.
Missing Finnish translations for new localization-check keys.
Both keys are added with English values:
LOCCheckLocalizationUpdateWhenHasManualLOCCheckLocalizationAddedSimilarWhenManual
Please translate them into Finnish. For example:
<sys:String x:Key="LOCCheckLocalizationUpdateWhenHasManual">Voidaan päivittää liitännätiedot, kun manuaalisia merkintöjä on</sys:String>
<sys:String x:Key="LOCCheckLocalizationAddedSimilarWhenManual">Voidaan lisätä saman kielen liitännätiedot manuaalisesti</sys:String>| <?xml version="1.0"?> | ||
| <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:sys="clr-namespace:System;assembly=mscorlib"> | ||
|
|
||
| <sys:String x:Key="LOCCheckLocalizationsFlag">Flag</sys:String> |
There was a problem hiding this comment.
Missing Finnish translation for LOCCheckLocalizationsFlag.
The value is currently "Flag" in English. Please translate it to Finnish (e.g., "Lippu").
Summary by CodeRabbit
New Features
Improvements
Bug Fixes