Basic light mode styling#239
Open
jerryjappinen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic light mode support shows the web site with light styles. Respects the active browser/OS setting. Light mode support helps adapt the site to user preferences and improves accessibility in some situations (e.g. poor lighting conditions).
Sponsor logo backgrounds are always dark, so that a negative logo remains visible. You could make the SVG assets dynamic but I left them the way they were, so you don't need to think about it when adding sponsors, for example.
The header is also always dark as I could only find a negative version of the Ladybird logo.
Note: I got this error message after running the build command, before I made any changes and also after. Build was successful though.