copy player list on sync (fixes #221)

UpcraftLP · UpcraftLP · commit b95e8fa3b851 · 2025-11-21T20:35:15.000+01:00
diff --git a/cardinal-components-world/src/main/java/org/ladysnake/cca/mixin/world/common/MixinServerWorld.java b/cardinal-components-world/src/main/java/org/ladysnake/cca/mixin/world/common/MixinServerWorld.java
@@ -72,7 +72,9 @@ private void tick(BooleanSupplier shouldKeepTicking, CallbackInfo ci) {
 
     @Override
     public Iterable<ServerPlayerEntity> getRecipientsForComponentSync() {
-        return this.getPlayers();
+        // Need to copy the player list because it might be modified off-thread
+        // https://github.com/Ladysnake/Cardinal-Components-API/issues/221
+        return List.copyOf(this.getPlayers());
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,9 @@ private void tick(BooleanSupplier shouldKeepTicking, CallbackInfo ci) {`
`72`	`72`
`73`	`73`	`@Override`
`74`	`74`	`public Iterable<ServerPlayerEntity> getRecipientsForComponentSync() {`
`75`		`- return this.getPlayers();`
	`75`	`+ // Need to copy the player list because it might be modified off-thread`
	`76`	`+ // https://github.com/Ladysnake/Cardinal-Components-API/issues/221`
	`77`	`+ return List.copyOf(this.getPlayers());`
`76`	`78`	`}`
`77`	`79`
`78`	`80`	`@Override`